Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2625523002: Reland of Update MANIFEST.json to newest version. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, dewittj
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jeffcarp, jsbell, sunjian, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Update MANIFEST.json to newest version. (patchset #3 id:20001 of https://codereview.chromium.org/2619613002/ ) Reason for revert: Test expectations were updated in http://crrev.com/2614253003, so layout test baselines and expectations should be up-to-date. Original issue's description: > Revert of: > > "Import wpt@eeecf3e14368d4ab5221cde688003dedeca30dba" > This reverts commit cfd8c14d3a0f7fd474248428d230845812848038. > > "Update MANIFEST.json to newest version." > This reverts commit dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d. > > Reason for revert: > Begins running layout tests without proper expectations. > > Original issue's description: > > Update MANIFEST.json to newest version. > > > > Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed http://crbug.com/678077 for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt. > > > > This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly. > > > > TBR=dpranke > > > > BUG=678077 > > > > Review-Url: https://codereview.chromium.org/2615903004 . > > Cr-Commit-Position: refs/heads/master@{#441999} > > Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d > > TBR=dpranke@chromium.org,qyearsley@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=678077 > > Review-Url: https://codereview.chromium.org/2619613002 . > Cr-Commit-Position: refs/heads/master@{#442054} > Committed: https://chromium.googlesource.com/chromium/src/+/e0615e1b33112564698760629bef4b56d80572cd R=dpranke@chromium.org TBR=dewittj@chromium.org, dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=678077 Review-Url: https://codereview.chromium.org/2625523002 . Cr-Commit-Position: refs/heads/master@{#442457} Committed: https://chromium.googlesource.com/chromium/src/+/1297046888300e6524fd1aab198e78bf67481674

Patch Set 1 #

Patch Set 2 : Add manifest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch

Messages

Total messages: 11 (3 generated)
qyearsley
Created Reland of Update MANIFEST.json to newest version.
3 years, 11 months ago (2017-01-09 21:32:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625523002/1
3 years, 11 months ago (2017-01-09 21:33:27 UTC) #3
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-09 21:43:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/337690)
3 years, 11 months ago (2017-01-09 21:47:18 UTC) #6
qyearsley
On 2017/01/09 at 21:47:18, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
3 years, 11 months ago (2017-01-09 21:57:36 UTC) #7
qyearsley
Committed patchset #2 (id:10001) manually as 1297046888300e6524fd1aab198e78bf67481674 (presubmit successful).
3 years, 11 months ago (2017-01-10 02:51:17 UTC) #9
Timothy Loh
On 2017/01/10 02:51:17, qyearsley wrote: > Committed patchset #2 (id:10001) manually as > 1297046888300e6524fd1aab198e78bf67481674 (presubmit ...
3 years, 11 months ago (2017-01-10 04:13:02 UTC) #10
qyearsley
3 years, 11 months ago (2017-01-10 05:43:15 UTC) #11
Message was sent while issue was closed.
On 2017/01/10 at 04:13:02, timloh wrote:
> On 2017/01/10 02:51:17, qyearsley wrote:
> > Committed patchset #2 (id:10001) manually as
> > 1297046888300e6524fd1aab198e78bf67481674 (presubmit successful).
> 
> Looks like this has broken about 15-20 tests on several (all?) platforms, e.g.
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/49438
> 
> Could you have a look and fix, otherwise I'll add TestExpectation entries for
these.
> 
>
imported/wpt/web-animations/animation-model/animation-types/spacing-keyframes-transform.html
> imported/csswg-test/css-flexbox-1/flexbox_flex-natural-mixed-basis-auto.html
>
imported/wpt/web-animations/animation-model/animation-types/interpolation-per-property.html
>
imported/wpt/web-animations/interfaces/KeyframeEffectReadOnly/copy-contructor.html
>
imported/wpt/web-animations/animation-model/animation-types/spacing-keyframes-shapes.html
> imported/csswg-test/css-flexbox-1/flex-minimum-width-flex-items-003.xht
>
imported/wpt/web-animations/animation-model/animation-types/addition-per-property.html
> imported/wpt/html/syntax/parsing/html5lib_innerHTML_foreign-fragment.html
>
imported/wpt/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html
> imported/wpt/html/syntax/parsing/html5lib_innerHTML_webkit02.html
> imported/wpt/web-animations/interfaces/KeyframeEffect/composite.html
>
imported/wpt/web-animations/animation-model/combining-effects/effect-composition.html
>
imported/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
> imported/csswg-test/css-flexbox-1/flex-minimum-width-flex-items-001.xht
>
imported/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html
> imported/wpt/html/syntax/parsing/html5lib_innerHTML_adoption01.html
> imported/wpt/web-animations/interfaces/KeyframeEffect/copy-contructor.html
>
imported/wpt/web-animations/animation-model/animation-types/spacing-keyframes-filters.html
>
imported/wpt/html/browsers/history/the-location-interface/location-pathname-setter-question-mark.html

Will take a look now!

Powered by Google App Engine
This is Rietveld 408576698