Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2619613002: Revert of Update MANIFEST.json to newest version. (Closed)

Created:
3 years, 11 months ago by dewittj
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jeffcarp, jsbell, sunjian, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of: "Import wpt@eeecf3e14368d4ab5221cde688003dedeca30dba" This reverts commit cfd8c14d3a0f7fd474248428d230845812848038. "Update MANIFEST.json to newest version." This reverts commit dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d. Reason for revert: Begins running layout tests without proper expectations. Original issue's description: > Update MANIFEST.json to newest version. > > Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed http://crbug.com/678077 for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt. > > This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly. > > TBR=dpranke > > BUG=678077 > > Review-Url: https://codereview.chromium.org/2615903004 . > Cr-Commit-Position: refs/heads/master@{#441999} > Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d TBR=dpranke@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678077 Review-Url: https://codereview.chromium.org/2619613002 . Cr-Commit-Position: refs/heads/master@{#442054} Committed: https://chromium.googlesource.com/chromium/src/+/e0615e1b33112564698760629bef4b56d80572cd

Patch Set 1 #

Patch Set 2 : Revert "Update MANIFEST.json to newest version." #

Patch Set 3 : Also revert the subsequent roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch

Messages

Total messages: 5 (2 generated)
dewittj
Created Revert of Update MANIFEST.json to newest version.
3 years, 11 months ago (2017-01-06 21:04:52 UTC) #1
dewittj
Committed patchset #3 (id:20001) manually as e0615e1b33112564698760629bef4b56d80572cd (presubmit successful).
3 years, 11 months ago (2017-01-06 21:21:35 UTC) #4
qyearsley
3 years, 11 months ago (2017-01-09 21:32:46 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:20001) has been created in
https://codereview.chromium.org/2625523002/ by qyearsley@chromium.org.

The reason for reverting is: Test expectations were updated in
http://crrev.com/2614253003, so layout test baselines and expectations should be
up-to-date..

Powered by Google App Engine
This is Rietveld 408576698