Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2615903004: Update MANIFEST.json to newest version. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jeffcarp, jsbell, sunjian, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update MANIFEST.json to newest version. Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed http://crbug.com/678077 for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt. This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly. TBR=dpranke BUG=678077 Review-Url: https://codereview.chromium.org/2615903004 . Cr-Commit-Position: refs/heads/master@{#441999} Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 11 months ago (2017-01-06 18:20:54 UTC) #3
qyearsley
Note: the MANIFEST.json file is 53806 lines (1.4M) and the overall file structure is now: ...
3 years, 11 months ago (2017-01-06 18:34:00 UTC) #4
qyearsley
Committed patchset #1 (id:1) manually as dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d (presubmit successful).
3 years, 11 months ago (2017-01-06 19:05:40 UTC) #7
dewittj
3 years, 11 months ago (2017-01-06 21:04:52 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2619613002/ by dewittj@chromium.org.

The reason for reverting is: Begins running layout tests without proper
expectations..

Powered by Google App Engine
This is Rietveld 408576698