Prefer newly added SkPaint::refFoo() over getFoo()

third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
index 529f705b6fd2266d522860b6ad5bd86665017518..32f7e3d6f16f170e65ca826029ae9d6a35384c7a 100644
--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
@@ -443,10 +443,9 @@ void BaseRenderingContext2D::compositedDraw(
     if (filter) {
       SkPaint foregroundPaint =
           *state().getPaint(paintType, DrawForegroundOnly, imageType);
-      sk_sp<SkImageFilter> composedFilter =
-          sk_ref_sp(foregroundPaint.getImageFilter());
-      composedFilter = SkComposeImageFilter::Make(
-          std::move(composedFilter), sk_ref_sp(shadowPaint.getImageFilter()));
+      sk_sp<SkImageFilter> composedFilter = foregroundPaint.refImageFilter();

[reed1, 2017/01/12 19:09:31]

Is it too horrible to never use an lvalue for this tree?

setImageFilter(Compose(Compose(fg, shadow), filter)))

[f(malita), 2017/01/12 19:14:19]

Done.

+      composedFilter = SkComposeImageFilter::Make(std::move(composedFilter),
+                                                  shadowPaint.refImageFilter());
       composedFilter =
           SkComposeImageFilter::Make(std::move(composedFilter), filter);
       foregroundPaint.setImageFilter(std::move(composedFilter));