cc/output/software_renderer.cc - Issue 2625403002: Prefer newly added SkPaint::refFoo() over getFoo()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/software_renderer.cc

Issue 2625403002: Prefer newly added SkPaint::refFoo() over getFoo() (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/software_renderer.cc

diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc

index 57d4a057aa198731f06b6bc60c793db4f3bfbb7d..56ff0cbb012889913f2c2d7c1d686a9500433b98 100644

--- a/cc/output/software_renderer.cc

+++ b/cc/output/software_renderer.cc

@@ -547,7 +547,7 @@ void SoftwareRenderer::DrawRenderPassQuad(const DrawingFrame* frame,

if (background_filter_shader) {

SkPaint paint;

paint.setShader(std::move(background_filter_shader));

- paint.setRasterizer(sk_ref_sp(current_paint_.getRasterizer()));

+ paint.setRasterizer(current_paint_.refRasterizer());

current_canvas_->drawRect(dest_visible_rect, paint);

}

current_paint_.setShader(std::move(shader));