Prefer newly added SkPaint::refFoo() over getFoo()

third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BaseRenderingContext2D_h
 #define BaseRenderingContext2D_h
 
 #include "bindings/modules/v8/CSSImageValueOrHTMLImageElementOrHTMLVideoElementOrHTMLCanvasElementOrImageBitmapOrOffscreenCanvas.h"
 #include "bindings/modules/v8/StringOrCanvasGradientOrCanvasPattern.h"
 #include "core/html/ImageData.h"
@@ skipping 425 matching lines @@
   SkPaint compositePaint;
   compositePaint.setBlendMode((SkBlendMode)state().globalComposite());
   if (state().shouldDrawShadows()) {
     // unroll into two independently composited passes if drawing shadows
     SkPaint shadowPaint =
         *state().getPaint(paintType, DrawShadowOnly, imageType);
     int saveCount = c->getSaveCount();
     if (filter) {
       SkPaint foregroundPaint =
           *state().getPaint(paintType, DrawForegroundOnly, imageType);
-      sk_sp<SkImageFilter> composedFilter =
-          sk_ref_sp(foregroundPaint.getImageFilter());
-      composedFilter = SkComposeImageFilter::Make(
-          std::move(composedFilter), sk_ref_sp(shadowPaint.getImageFilter()));
+      sk_sp<SkImageFilter> composedFilter = foregroundPaint.refImageFilter();

[reed1, 2017/01/12 19:09:31]

Is it too horrible to never use an lvalue for this tree?

setImageFilter(Compose(Compose(fg, shadow), filter)))

[f(malita), 2017/01/12 19:14:19]

Done.

+      composedFilter = SkComposeImageFilter::Make(std::move(composedFilter),
+                                                  shadowPaint.refImageFilter());
       composedFilter =
           SkComposeImageFilter::Make(std::move(composedFilter), filter);
       foregroundPaint.setImageFilter(std::move(composedFilter));
       c->setMatrix(ctm);
       drawFunc(c, &foregroundPaint);
     } else {
       ASSERT(isFullCanvasCompositeMode(state().globalComposite()));
       c->saveLayer(nullptr, &compositePaint);
       shadowPaint.setBlendMode(SkBlendMode::kSrcOver);
       c->setMatrix(ctm);
       drawFunc(c, &shadowPaint);
     }
     c->restoreToCount(saveCount);
   }
 
   compositePaint.setImageFilter(std::move(filter));
   c->saveLayer(nullptr, &compositePaint);
   SkPaint foregroundPaint =
       *state().getPaint(paintType, DrawForegroundOnly, imageType);
   foregroundPaint.setBlendMode(SkBlendMode::kSrcOver);
   c->setMatrix(ctm);
   drawFunc(c, &foregroundPaint);
   c->restore();
   c->setMatrix(ctm);
 }
 
 }  // namespace blink
 
 #endif  // BaseRenderingContext2D_h