third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp - Issue 2625403002: Prefer newly added SkPaint::refFoo() over getFoo()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

Issue 2625403002: Prefer newly added SkPaint::refFoo() over getFoo() (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h ('K') | « third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h ('k') | third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

index 521f6f186aa2f3c26ad9361236fe753a0480e1ed..426c5b1ea4c50e4a36fe04303ba98c22c9c80cd3 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

@@ -1063,7 +1063,7 @@ void BaseRenderingContext2D::drawImageInternal(SkCanvas* c,

ctm.mapRect(&bounds);

SkPaint layerPaint;

layerPaint.setBlendMode(paint->getBlendMode());

- layerPaint.setImageFilter(sk_ref_sp(paint->getImageFilter()));

+ layerPaint.setImageFilter(paint->refImageFilter());

c->saveLayer(&bounds, &layerPaint);

c->concat(ctm);