Prefer newly added SkPaint::refFoo() over getFoo()

Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2625403002
Cr-Commit-Position: refs/heads/master@{#443355}
Committed: https://chromium.googlesource.com/chromium/src/+/ca6a69d41a70cf1fadb286ffe84321c2c90e2995

[f(malita), 2017-01-12 18:43:21]

Description was changed from

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
==========

to

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[f(malita), 2017-01-12 18:43:33]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 18:43:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-12 18:49:39]

Description was changed from

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[f(malita), 2017-01-12 18:49:40]

fmalita@chromium.org changed reviewers:
+ robertphillips@chromium.org

[reed1, 2017-01-12 19:09:31]

lgtm

https://codereview.chromium.org/2625403002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
(right):

https://codereview.chromium.org/2625403002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h:446:
sk_sp<SkImageFilter> composedFilter = foregroundPaint.refImageFilter();
Is it too horrible to never use an lvalue for this tree?

setImageFilter(Compose(Compose(fg, shadow), filter)))

[f(malita), 2017-01-12 19:13:59]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[f(malita), 2017-01-12 19:14:20]

https://codereview.chromium.org/2625403002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
(right):

https://codereview.chromium.org/2625403002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h:446:
sk_sp<SkImageFilter> composedFilter = foregroundPaint.refImageFilter();
On 2017/01/12 19:09:31, reed1 wrote:
> Is it too horrible to never use an lvalue for this tree?
> 
> setImageFilter(Compose(Compose(fg, shadow), filter)))

Done.

[commit-bot: I haz the power, 2017-01-12 19:14:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-12 20:25:29]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2017-01-12 20:30:37]

Description was changed from

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[f(malita), 2017-01-12 20:30:55]

TBR-ing, for trivial changes.

[f(malita), 2017-01-12 20:31:00]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-01-12 20:31:01]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2625403002/#ps20001
(title: "inline SkComposeImageFilter construction")

[commit-bot: I haz the power, 2017-01-12 20:31:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2017-01-12 20:33:02]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2017-01-12 20:33:03]

lgtm

[commit-bot: I haz the power, 2017-01-12 20:55:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484253060918450,
"parent_rev": "e09f6f26f363fd98d8a7a8e37ba4c0c71aa4ef63", "commit_rev":
"ca6a69d41a70cf1fadb286ffe84321c2c90e2995"}

[commit-bot: I haz the power, 2017-01-12 20:55:43]

Description was changed from

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Prefer newly added SkPaint::refFoo() over getFoo()

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2625403002
Cr-Commit-Position: refs/heads/master@{#443355}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca6a69d41a70cf1fadb286ffe843...
==========

[commit-bot: I haz the power, 2017-01-12 20:55:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ca6a69d41a70cf1fadb286ffe843...