Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

Issue 2625403002: Prefer newly added SkPaint::refFoo() over getFoo() (Closed)
Patch Set: inline SkComposeImageFilter construction Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp
index 9a2d86477bfb94a5299374ee58bc6fbdd392c123..fd075af191a292608c53ba4006716311355b0138 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp
@@ -90,7 +90,7 @@ void GraphicsContextState::setFillColor(const Color& color) {
// Shadow. (This will need tweaking if we use draw loopers for other things.)
void GraphicsContextState::setDrawLooper(sk_sp<SkDrawLooper> drawLooper) {
// Grab a new ref for stroke.
- m_strokePaint.setLooper(sk_ref_sp(drawLooper.get()));
+ m_strokePaint.setLooper(drawLooper);
// Pass the existing ref to fill (to minimize refcount churn).
m_fillPaint.setLooper(std::move(drawLooper));
}
@@ -102,7 +102,7 @@ void GraphicsContextState::setLineDash(const DashArray& dashes,
void GraphicsContextState::setColorFilter(sk_sp<SkColorFilter> colorFilter) {
// Grab a new ref for stroke.
- m_strokePaint.setColorFilter(sk_ref_sp(colorFilter.get()));
+ m_strokePaint.setColorFilter(colorFilter);
// Pass the existing ref to fill (to minimize refcount churn).
m_fillPaint.setColorFilter(std::move(colorFilter));
}
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698