Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2624823002: Remove unused service instance id from bluetooth BluetoothRemoteGATTCharacteristic (Closed)

Created:
3 years, 11 months ago by dougt
Modified:
3 years, 11 months ago
Reviewers:
scheib, juncai
CC:
chromium-reviews, blink-reviews, haraken, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused service instance id from bluetooth BluetoothRemoteGATTCharacteristic Since fixing bug 676702 and 597053, we no longer need the string BluetoothRemoteGATTCharacteristic::m_serviceInstanceId. R=juncai BUG=None Review-Url: https://codereview.chromium.org/2624823002 Cr-Commit-Position: refs/heads/master@{#442793} Committed: https://chromium.googlesource.com/chromium/src/+/31a3f75562091491b6b0c2941a9c845407fb38c2

Patch Set 1 #

Messages

Total messages: 15 (10 generated)
dougt
scheib@chromium.org: PTAL
3 years, 11 months ago (2017-01-10 21:20:42 UTC) #4
juncai
LGTM with nits: 1. It seems that the "used" in the title should be "unused"? ...
3 years, 11 months ago (2017-01-10 21:29:26 UTC) #7
scheib
LGTM
3 years, 11 months ago (2017-01-11 04:04:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624823002/1
3 years, 11 months ago (2017-01-11 04:04:47 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 04:12:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31a3f75562091491b6b0c2941a9c...

Powered by Google App Engine
This is Rietveld 408576698