third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp - Issue 2624823002: Remove unused service instance id from bluetooth BluetoothRemoteGATTCharacteristic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2624823002: Remove unused service instance id from bluetooth BluetoothRemoteGATTCharacteristic (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

index 9a557735190a9c677f2436db682a1c7318dae5a2..49afc52a55db0975f90dc16405d68650860dd2e6 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

@@ -42,12 +42,10 @@ DOMDataView* ConvertWTFVectorToDataView(const Vector<uint8_t>& wtfVector) {

BluetoothRemoteGATTCharacteristic::BluetoothRemoteGATTCharacteristic(

ExecutionContext* context,

- const String& serviceInstanceId,

mojom::blink::WebBluetoothRemoteGATTCharacteristicPtr characteristic,

BluetoothRemoteGATTService* service,

BluetoothDevice* device)

: ContextLifecycleObserver(context),

- m_serviceInstanceId(serviceInstanceId),

m_characteristic(std::move(characteristic)),

m_service(service),

m_stopped(false),

@@ -58,12 +56,11 @@ BluetoothRemoteGATTCharacteristic::BluetoothRemoteGATTCharacteristic(

BluetoothRemoteGATTCharacteristic* BluetoothRemoteGATTCharacteristic::create(

ExecutionContext* context,

- const String& serviceInstanceId,

mojom::blink::WebBluetoothRemoteGATTCharacteristicPtr characteristic,

BluetoothRemoteGATTService* service,

BluetoothDevice* device) {

return new BluetoothRemoteGATTCharacteristic(

- context, serviceInstanceId, std::move(characteristic), service, device);

+ context, std::move(characteristic), service, device);

}

void BluetoothRemoteGATTCharacteristic::setValue(DOMDataView* domDataView) {