third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp - Issue 2624823002: Remove unused service instance id from bluetooth BluetoothRemoteGATTCharacteristic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

Issue 2624823002: Remove unused service instance id from bluetooth BluetoothRemoteGATTCharacteristic (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

index 5cfa298e48b5e5f382a606c40bd7c0516f9968fd..dcc7a52da0030683533231be4c45b590751e7560 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp

@@ -41,7 +41,6 @@ bool BluetoothAttributeInstanceMap::containsService(

BluetoothRemoteGATTCharacteristic*

BluetoothAttributeInstanceMap::getOrCreateRemoteGATTCharacteristic(

ExecutionContext* context,

- const String& serviceInstanceId,

mojom::blink::WebBluetoothRemoteGATTCharacteristicPtr

remoteGATTCharacteristic,

BluetoothRemoteGATTService* service) {

@@ -51,8 +50,7 @@ BluetoothAttributeInstanceMap::getOrCreateRemoteGATTCharacteristic(

if (!characteristic) {

characteristic = BluetoothRemoteGATTCharacteristic::create(

- context, serviceInstanceId, std::move(remoteGATTCharacteristic),

- service, m_device);

+ context, std::move(remoteGATTCharacteristic), service, m_device);

m_characteristicIdToObject.add(instanceId, characteristic);

}