Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(62)

Issue 2624163002: [XHR] Add CHECK to make sure XHR::m_loader is not silently released (Closed)

Created:
11 months ago by yhirano
Modified:
11 months ago
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[XHR] Add CHECK to make sure XHR::m_loader is not silently released XMLHttpRequest::m_loader should be manually cancelled before it is released. This CL adds a CHECK to make sure the we keep the contract. BUG=667254 Review-Url: https://codereview.chromium.org/2624163002 Cr-Commit-Position: refs/heads/master@{#442921} Committed: https://chromium.googlesource.com/chromium/src/+/c197aaf856fea65148a930dd4219937d0749f12d

Patch Set 1 #

Patch Set 2 : fix #

Messages

Total messages: 22 (12 generated)
yhirano
11 months ago (2017-01-11 11:54:37 UTC) #5
sof
given the m_loader checks that are in place surrounding loadstart dispatching a bit further up, ...
11 months ago (2017-01-11 12:17:00 UTC) #6
yhirano
On 2017/01/11 12:17:00, sof wrote: > given the m_loader checks that are in place surrounding ...
11 months ago (2017-01-11 12:37:29 UTC) #7
sof
On 2017/01/11 12:37:29, yhirano wrote: > On 2017/01/11 12:17:00, sof wrote: > > given the ...
11 months ago (2017-01-11 12:46:50 UTC) #8
yhirano
On 2017/01/11 12:46:50, sof wrote: > On 2017/01/11 12:37:29, yhirano wrote: > > On 2017/01/11 ...
11 months ago (2017-01-11 13:07:56 UTC) #11
sof
lgtm to try
11 months ago (2017-01-11 13:21:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624163002/20001
11 months ago (2017-01-11 13:49:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98066)
11 months ago (2017-01-11 14:36:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624163002/20001
11 months ago (2017-01-11 15:11:45 UTC) #19
commit-bot: I haz the power
11 months ago (2017-01-11 16:26:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c197aaf856fea65148a930dd4219...

Powered by Google App Engine
This is Rietveld 0eb02b776