Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2624163002:
[XHR] Add CHECK to make sure XHR::m_loader is not silently released (Closed)
Description[XHR] Add CHECK to make sure XHR::m_loader is not silently released
XMLHttpRequest::m_loader should be manually cancelled before it is released.
This CL adds a CHECK to make sure the we keep the contract.
BUG=667254
Review-Url: https://codereview.chromium.org/2624163002
Cr-Commit-Position: refs/heads/master@{#442921}
Committed: https://chromium.googlesource.com/chromium/src/+/c197aaf856fea65148a930dd4219937d0749f12d
Patch Set 1 #Patch Set 2 : fix #Messages
Total messages: 22 (12 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [XHR] Add CHECK to make sure XHR::m_loader is not silently released XMLHttpRequest::m_loader should be manually cancelled before it is released. This CL adds a CHECK to make sure the we keep the contract. BUG=667254 ========== to ========== [XHR] Add CHECK to make sure XHR::m_loader is not silently released XMLHttpRequest::m_loader should be manually cancelled before it is released. This CL adds a CHECK to make sure the we keep the contract. BUG=667254 ==========
yhirano@chromium.org changed reviewers: + sigbjornf@opera.com, tyoshino@chromium.org
given the m_loader checks that are in place surrounding loadstart dispatching a bit further up, I don't see the motivation for making this a CHECK().
On 2017/01/11 12:17:00, sof wrote: > given the m_loader checks that are in place surrounding loadstart dispatching a > bit further up, I don't see the motivation for making this a CHECK(). Me neither, but I'm not trusting myself right now. We had some bugs around |m_loader| here, such as https://codereview.chromium.org/2271033003 and https://codereview.chromium.org/2507773002 so I may be missing something.
On 2017/01/11 12:37:29, yhirano wrote: > On 2017/01/11 12:17:00, sof wrote: > > given the m_loader checks that are in place surrounding loadstart dispatching > a > > bit further up, I don't see the motivation for making this a CHECK(). > > Me neither, but I'm not trusting myself right now. We had some bugs around > |m_loader| here, such as https://codereview.chromium.org/2271033003 and > https://codereview.chromium.org/2507773002 so I may be missing something. Following the latter CL, I don't see where |m_loader| can be set by the intervening code. But i'm ok with landing it if you add a TODO indicating that it will be retired reasonably soon. CHECK()s can be hard to later unlodge&remove without.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/11 12:46:50, sof wrote: > On 2017/01/11 12:37:29, yhirano wrote: > > On 2017/01/11 12:17:00, sof wrote: > > > given the m_loader checks that are in place surrounding loadstart > dispatching > > a > > > bit further up, I don't see the motivation for making this a CHECK(). > > > > Me neither, but I'm not trusting myself right now. We had some bugs around > > |m_loader| here, such as https://codereview.chromium.org/2271033003 and > > https://codereview.chromium.org/2507773002 so I may be missing something. > > Following the latter CL, I don't see where |m_loader| can be set by the > intervening code. > > But i'm ok with landing it if you add a TODO indicating that it will be retired > reasonably soon. CHECK()s can be hard to later unlodge&remove without. Thanks, I added a TODO comment, and add one more CHECK for the sync case.
lgtm to try
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484147482840990,
"parent_rev": "0fc24d12c8b88f8703321ba4470692b717bd381e", "commit_rev":
"c197aaf856fea65148a930dd4219937d0749f12d"}
Message was sent while issue was closed.
Description was changed from ========== [XHR] Add CHECK to make sure XHR::m_loader is not silently released XMLHttpRequest::m_loader should be manually cancelled before it is released. This CL adds a CHECK to make sure the we keep the contract. BUG=667254 ========== to ========== [XHR] Add CHECK to make sure XHR::m_loader is not silently released XMLHttpRequest::m_loader should be manually cancelled before it is released. This CL adds a CHECK to make sure the we keep the contract. BUG=667254 Review-Url: https://codereview.chromium.org/2624163002 Cr-Commit-Position: refs/heads/master@{#442921} Committed: https://chromium.googlesource.com/chromium/src/+/c197aaf856fea65148a930dd4219... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c197aaf856fea65148a930dd4219... |
