Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2271033003:
Suppress cancellation notification in XMLHttpRequest::endLoading (Closed)
|
Created:
4 years, 3 months ago by yhirano Modified:
4 years, 3 months ago Reviewers:
tyoshino (SeeGerritForStatus) CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSuppress cancellation notification in XMLHttpRequest::endLoading
We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it
is required by ThreadableLoader, but that cancellation should not be
notified to JS. Otherwise, the script can replace |m_loader| in the
XMLHttpRequest instance and that violates the ThreadableLoader assumption
itself.
BUG=638567, 638432
Committed: https://crrev.com/44a428232115791ba479e01981a5450c8500ee70
Cr-Commit-Position: refs/heads/master@{#414026}
Patch Set 1 : fix #
Messages
Total messages: 23 (16 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== xhr crash fix BUG= ========== to ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567 ==========
yhirano@chromium.org changed reviewers: + tyoshino@chromium.org
yhirano@chromium.org changed reviewers: + japhet@chromium.org
yhirano@chromium.org changed reviewers: - japhet@chromium.org
lgtm
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567 ========== to ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567, 638432 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567, 638432 ========== to ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567, 638432 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567, 638432 ========== to ========== Suppress cancellation notification in XMLHttpRequest::endLoading We call ThreadableLoader::cancel in XMLHttpRequest::endLoading as it is required by ThreadableLoader, but that cancellation should not be notified to JS. Otherwise, the script can replace |m_loader| in the XMLHttpRequest instance and that violates the ThreadableLoader assumption itself. BUG=638567, 638432 Committed: https://crrev.com/44a428232115791ba479e01981a5450c8500ee70 Cr-Commit-Position: refs/heads/master@{#414026} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/44a428232115791ba479e01981a5450c8500ee70 Cr-Commit-Position: refs/heads/master@{#414026} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
