Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2507773002: XMLHttpRequest: check if 'loadstart' handler cancelled send(). (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

XMLHttpRequest: check if 'loadstart' handler cancelled send(). 'loadstart' is dispatched to both 'download' and upload event handlers while initiating a send() operation. Should those event handlers cause the ongoing send operation to be aborted/stopped/cancelled, this outer send() operation shouldn't proceed upon return. R=yhirano BUG=642242 Committed: https://crrev.com/13c30eae8fbe5a1b9927c12be1cd88d102009932 Cr-Commit-Position: refs/heads/master@{#433157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/onloadstart-abort.html View 1 chunk +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sof
please take a look. WPT's abort-event-loadend.htm already runs into this case, albeit "unintentionally". So I ...
4 years, 1 month ago (2016-11-16 14:21:03 UTC) #4
yhirano
lgtm
4 years, 1 month ago (2016-11-18 02:17:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507773002/1
4 years, 1 month ago (2016-11-18 07:42:15 UTC) #10
sof
thanks, landing. Will follow up on any spec changes, once those are decided.
4 years, 1 month ago (2016-11-18 08:30:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 09:07:55 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:09:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13c30eae8fbe5a1b9927c12be1cd88d102009932
Cr-Commit-Position: refs/heads/master@{#433157}

Powered by Google App Engine
This is Rietveld 408576698