Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2624043002: Eliminate loadTimeData dependency from cr_elements/policy (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate loadTimeData dependency from cr_elements/policy BUG=670767 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2624043002 Cr-Commit-Position: refs/heads/master@{#443100} Committed: https://chromium.googlesource.com/chromium/src/+/7482287f45c241d6fa567c6037c87382ec7b79a1

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Show icons (just not tooltips) if CrPolicyStrings is not defiend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -34 lines) Patch
M chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js View 1 2 2 chunks +26 lines, -18 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js View 1 1 chunk +5 lines, -9 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js View 1 1 chunk +3 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
stevenjb
LMKWYT
3 years, 11 months ago (2017-01-11 17:06:52 UTC) #3
Dan Beam
lgtm \o/
3 years, 11 months ago (2017-01-11 18:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624043002/20001
3 years, 11 months ago (2017-01-11 19:07:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/291128)
3 years, 11 months ago (2017-01-11 20:15:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624043002/40001
3 years, 11 months ago (2017-01-11 20:30:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211295)
3 years, 11 months ago (2017-01-11 20:50:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624043002/40001
3 years, 11 months ago (2017-01-11 21:50:43 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:09:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7482287f45c241d6fa567c6037c8...

Powered by Google App Engine
This is Rietveld 408576698