Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js

Issue 2624043002: Eliminate loadTimeData dependency from cr_elements/policy (Closed)
Patch Set: Show icons (just not tooltips) if CrPolicyStrings is not defiend Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
diff --git a/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js b/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
index a76a4c6e7ca747358d03d8bd69c2bf27823f9181..dcb58c425f3253a9db5dc88c38f1dc26607f2ced 100644
--- a/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
+++ b/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
@@ -37,11 +37,8 @@ Polymer({
* @private
*/
getTooltip_: function(type, pref) {
- if (type == CrPolicyIndicatorType.RECOMMENDED) {
- if (pref && pref.value == pref.recommendedValue)
- return this.i18n_('controlledSettingRecommendedMatches');
- return this.i18n_('controlledSettingRecommendedDiffers');
- }
- return this.getPolicyIndicatorTooltip(type, pref.controlledByName || '');
+ var matches = pref && pref.value == pref.recommendedValue;
+ return this.getPolicyIndicatorTooltip(
+ type, pref.controlledByName || '', matches);
}
});
« no previous file with comments | « ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698