Issue 2623563003: [HBD] Update Cocoa to match removed controls from Plugins Blocked popup.

Issue 2623563003: [HBD] Update Cocoa to match removed controls from Plugins Blocked popup. (Closed)

Created:
3 years, 11 months ago by tommycli

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[HBD] Update Cocoa to match removed controls from Plugins Blocked popup. This CL leaves the xib files alone, but manually removes the unneeded controls in the .mm file to match the Views version. The Views code was changed in this CL: https://codereview.chromium.org/2552343005 BUG=674062 Review-Url: https://codereview.chromium.org/2593743002 Cr-Commit-Position: refs/heads/master@{#440139} (cherry picked from commit 9a463996fbbbde1dbee191d29b28cfa16a4eb0fb) Review-Url: https://codereview.chromium.org/2623563003 . Cr-Commit-Position: refs/branch-heads/2924@{#710} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm	View		4 chunks	+32 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

tommycli

3 years, 11 months ago (2017-01-10 02:02:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8.