Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2593743002: [HBD] Update Cocoa to match removed controls from Plugins Blocked popup. (Closed)

Created:
4 years ago by tommycli
Modified:
3 years, 12 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Update Cocoa to match removed controls from Plugins Blocked popup. This CL leaves the xib files alone, but manually removes the unneeded controls in the .mm file to match the Views version. The Views code was changed in this CL: https://codereview.chromium.org/2552343005 BUG=674062 Committed: https://crrev.com/9a463996fbbbde1dbee191d29b28cfa16a4eb0fb Cr-Commit-Position: refs/heads/master@{#440139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 4 chunks +32 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tommycli
erikchen, bauerb: PTAL This CL makes the Mac Cocoa match the Views UI. screenshots here: ...
4 years ago (2016-12-20 18:31:45 UTC) #4
erikchen
This looks like reasonable, thanks! lgtm
4 years ago (2016-12-20 18:36:55 UTC) #5
tommycli
On 2016/12/20 18:36:55, erikchen wrote: > This looks like reasonable, thanks! > > lgtm erikchen: ...
4 years ago (2016-12-20 23:33:20 UTC) #8
Bernhard Bauer
lgtm
4 years ago (2016-12-21 09:59:41 UTC) #9
tommycli
On 2016/12/21 09:59:41, Bernhard Bauer wrote: > lgtm Thanks!
3 years, 12 months ago (2016-12-21 17:26:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593743002/1
3 years, 12 months ago (2016-12-21 17:26:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-21 17:33:48 UTC) #15
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 17:36:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a463996fbbbde1dbee191d29b28cfa16a4eb0fb
Cr-Commit-Position: refs/heads/master@{#440139}

Powered by Google App Engine
This is Rietveld 408576698