Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 2552343005: [HBD] Remove radio buttons from the Plugins Blocked Omnibox popup. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Remove radio buttons from the Plugins Blocked Omnibox popup. This CL does two things to the Plugins Block Omnibox popup: 1. Removes the radio buttons. They are misleading and irrelevant in the HBD world, and weren't actually that useful in the pre-HBD world either. 2. Hides the Run All Plugins link in the policy-managed BLOCK case or the HBD BLOCK case. 3. Hides the Manage... link in the policy-managed case. User cannot manage the setting anyways. BUG=655899 Committed: https://crrev.com/cee4c12b4204f5ab1211903d0b5fd0da8b8b5c90 Cr-Commit-Position: refs/heads/master@{#437653}

Patch Set 1 #

Patch Set 2 : update unit test #

Patch Set 3 : hide manage text when policy managed #

Patch Set 4 : one more update #

Patch Set 5 : remove unneeded variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -86 lines) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 3 4 8 chunks +37 lines, -75 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (20 generated)
tommycli
bauerb: PTAL. Screenshots and UI review in bug. Thanks!
4 years ago (2016-12-08 21:46:12 UTC) #10
Bernhard Bauer
lgtm
4 years ago (2016-12-09 14:55:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552343005/80001
4 years ago (2016-12-09 19:09:15 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-09 21:09:24 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:52 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cee4c12b4204f5ab1211903d0b5fd0da8b8b5c90
Cr-Commit-Position: refs/heads/master@{#437653}

Powered by Google App Engine
This is Rietveld 408576698