Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 2623203003: [wasm] Patch the native context embedded in compiled code (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Patch the native context embedded in compiled code R=titzer@chromium.org BUG=chromium:673297 Review-Url: https://codereview.chromium.org/2623203003 Cr-Commit-Position: refs/heads/master@{#42282} Committed: https://chromium.googlesource.com/v8/v8/+/ddbfbefc0b6482399121ac4afa41d8784d868332

Patch Set 1 #

Patch Set 2 : Set context in the WCM on instantiation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M src/wasm/wasm-module.cc View 1 6 chunks +31 lines, -12 lines 0 comments Download
A test/mjsunit/regress/regress-673297.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-stack.js View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
Clemens Hammacher
3 years, 11 months ago (2017-01-12 12:44:16 UTC) #7
titzer
LGTM The long term goal should be to refactor the way we do patching to ...
3 years, 11 months ago (2017-01-12 12:54:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623203003/20001
3 years, 11 months ago (2017-01-12 18:15:06 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:30:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ddbfbefc0b6482399121ac4afa41d8784d8...

Powered by Google App Engine
This is Rietveld 408576698