Refactor FrameSummary for JS and Wasm frames

Refactor FrameSummary for JS and Wasm frames

Wasm frames can be either compiled or interpreted. For interpreted wasm
frames, there is only one physical stack frame representing an
arbitrary stack of interpreted functions. Hence the physical stack
frame needs to provide a summary of the underlying functions.
Summaries were tailored for JavaScript frames before. Now they are
universal.

The refactored FrameSummaries are now also used in the FrameInspector,
and from the StackFrame objects themselves, to avoid code duplication.

All dispatch is implemented "manually", making the FrameSummary still
stack-allocatable.

BUG=v8:5822
R=yangguo@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2619353006
Cr-Commit-Position: refs/heads/master@{#42279}
Committed: https://chromium.googlesource.com/v8/v8/+/df5417ae7640de40e2342ad0c16a64f4138279bc

[Clemens Hammacher, 2017-01-10 14:42:50]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:43:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 15:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 15:15:52]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-01-12 11:22:00]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 11:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 11:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 11:54:45]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-12 14:19:45]

lgtm

https://codereview.chromium.org/2619353006/diff/20001/src/debug/debug-frames.cc
File src/debug/debug-frames.cc (right):

https://codereview.chromium.org/2619353006/diff/20001/src/debug/debug-frames....
src/debug/debug-frames.cc:15: FrameSummary GetFrameSummary(StandardFrame* frame,
int index) {
This is sort of what FrameSummary::GetFirst does. I'd just put this code in
FrameSummary as well and implement GetFirst through this.

[Clemens Hammacher, 2017-01-12 14:55:01]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[Clemens Hammacher, 2017-01-12 14:55:07]

https://codereview.chromium.org/2619353006/diff/20001/src/debug/debug-frames.cc
File src/debug/debug-frames.cc (right):

https://codereview.chromium.org/2619353006/diff/20001/src/debug/debug-frames....
src/debug/debug-frames.cc:15: FrameSummary GetFrameSummary(StandardFrame* frame,
int index) {
On 2017/01/12 at 14:19:45, Yang wrote:
> This is sort of what FrameSummary::GetFirst does. I'd just put this code in
FrameSummary as well and implement GetFirst through this.

Great! Done.

[commit-bot: I haz the power, 2017-01-12 14:55:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-12 15:00:16]

lgtm

[commit-bot: I haz the power, 2017-01-12 15:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:24:24]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-01-12 16:51:40]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2017-01-12 16:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2619353006/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2017-01-12 16:51:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:54:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484239900326320,
"parent_rev": "53137df89a859fca258f9c448dec5a4eba4e47c7", "commit_rev":
"df5417ae7640de40e2342ad0c16a64f4138279bc"}

[commit-bot: I haz the power, 2017-01-12 16:54:34]

Description was changed from

==========
Refactor FrameSummary for JS and Wasm frames

Wasm frames can be either compiled or interpreted. For interpreted wasm
frames, there is only one physical stack frame representing an
arbitrary stack of interpreted functions. Hence the physical stack
frame needs to provide a summary of the underlying functions.
Summaries were tailored for JavaScript frames before. Now they are
universal.

The refactored FrameSummaries are now also used in the FrameInspector,
and from the StackFrame objects themselves, to avoid code duplication.

All dispatch is implemented "manually", making the FrameSummary still
stack-allocatable.

BUG=v8:5822
R=yangguo@chromium.org, titzer@chromium.org
==========

to

==========
Refactor FrameSummary for JS and Wasm frames

Wasm frames can be either compiled or interpreted. For interpreted wasm
frames, there is only one physical stack frame representing an
arbitrary stack of interpreted functions. Hence the physical stack
frame needs to provide a summary of the underlying functions.
Summaries were tailored for JavaScript frames before. Now they are
universal.

The refactored FrameSummaries are now also used in the FrameInspector,
and from the StackFrame objects themselves, to avoid code duplication.

All dispatch is implemented "manually", making the FrameSummary still
stack-allocatable.

BUG=v8:5822
R=yangguo@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2619353006
Cr-Commit-Position: refs/heads/master@{#42279}
Committed:
https://chromium.googlesource.com/v8/v8/+/df5417ae7640de40e2342ad0c16a64f4138...
==========

[commit-bot: I haz the power, 2017-01-12 16:54:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/df5417ae7640de40e2342ad0c16a64f4138...