Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2624383003: [wasm] Skip whole function linking phase (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Skip whole function linking phase As functions are relinked at instantiation anyway, we can just completely skip the LinkFunctions pass at wasm compile time. This way, we also don't need to create one placeholder per wasm function, but we just use one placeholder everywhere. The function index which was stored in the placeholder before is now retrieved from the wire bytes anyway. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2624383003 Cr-Commit-Position: refs/heads/master@{#42285} Committed: https://chromium.googlesource.com/v8/v8/+/723aeeaba2d672657675306004b9e91fdc396ee6

Patch Set 1 #

Patch Set 2 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -64 lines) Patch
M src/wasm/wasm-module.cc View 1 5 chunks +11 lines, -64 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
Clemens Hammacher
3 years, 11 months ago (2017-01-12 15:13:02 UTC) #7
titzer
Yes, this is awesome! Bye bye placeholders! LGTM
3 years, 11 months ago (2017-01-12 15:17:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624383003/20001
3 years, 11 months ago (2017-01-12 19:27:56 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:30:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/723aeeaba2d672657675306004b9e91fdc3...

Powered by Google App Engine
This is Rietveld 408576698