Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------

Review-Url: https://codereview.chromium.org/2622893003
Cr-Commit-Position: refs/heads/master@{#442920}
Committed: https://chromium.googlesource.com/chromium/src/+/0fc24d12c8b88f8703321ba4470692b717bd381e

[Evan Stade, 2017-01-10 16:51:06]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-10 17:05:02]

Description was changed from

==========
Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------
==========

to

==========
Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

Adding ASH_EXPORT fixes the component build (locally).

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------
==========

[Evan Stade, 2017-01-10 17:05:02]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2017-01-10 17:18:53]

Description was changed from

==========
Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

Adding ASH_EXPORT fixes the component build (locally).

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------
==========

to

==========
Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------
==========

[Evan Stade, 2017-01-10 17:20:59]

working fix is in patchset 2. I don't understand why this is necessary when
ash/BUILD.gn has the target in its public_deps. I can't find much in the way of
docs concerning public_deps.

[Evan Stade, 2017-01-10 17:21:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 17:21:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 18:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:27:20]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-01-11 02:19:40]

ok, we did need to update the build deps for ash_unittests as well. I still
don't know what public_deps actually does.

The ASH_EXPORT change seems neither sufficient nor necessary. From the GCC docs
I can find I think ASH_EXPORT is only necessary for functions. extern variables
shouldn't need it because our -fvisibility=hidden config doesn't apply to them.
ASH_EXPORT was probably useful for Windows externs but we no longer care about
that I suppose.

[1] https://cs.chromium.org/chromium/src/ash/ash_export.h?rcl=0&l=22

[Evan Stade, 2017-01-11 02:20:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-01-11 02:20:16]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-11 02:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-11 02:20:23]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-11 04:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:15:14]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sky, 2017-01-11 04:15:41]

LGTM

[Evan Stade, 2017-01-11 04:34:42]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:35:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:13:18]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Evan Stade, 2017-01-11 15:46:29]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:46:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:24:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484149589194700,
"parent_rev": "36860c01c1913acd255129a9024e22928f934d0e", "commit_rev":
"0fc24d12c8b88f8703321ba4470692b717bd381e"}

[commit-bot: I haz the power, 2017-01-11 16:24:33]

Description was changed from

==========
Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------
==========

to

==========
Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
------------------------

Review-Url: https://codereview.chromium.org/2622893003
Cr-Commit-Position: refs/heads/master@{#442920}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fc24d12c8b88f8703321ba44706...
==========

[commit-bot: I haz the power, 2017-01-11 16:24:34]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0fc24d12c8b88f8703321ba44706...