Move more vector icons to respective directories and update code to

Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
Review-Url: https://codereview.chromium.org/2620613005
Cr-Commit-Position: refs/heads/master@{#442488}
Committed: https://chromium.googlesource.com/chromium/src/+/f5157480667e99269e0062e9df1df3875db85197

[Evan Stade, 2017-01-10 00:57:44]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-01-10 00:58:58]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2017-01-10 00:58:59]

mostly mechanical changes aside from {Toggle,}ImageButton

[commit-bot: I haz the power, 2017-01-10 00:59:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:01:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sky, 2017-01-10 03:30:33]

LGTM

[Evan Stade, 2017-01-10 04:06:21]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-01-10 04:06:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:59:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484021181755150, "parent_rev":
"a52322134679a349366417e04e502bc8ce1f68e4", "commit_rev":
"f5157480667e99269e0062e9df1df3875db85197"}

[commit-bot: I haz the power, 2017-01-10 05:00:18]

Description was changed from

==========
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786
==========

to

==========
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG=626786

Review-Url: https://codereview.chromium.org/2620613005
Cr-Commit-Position: refs/heads/master@{#442488}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5157480667e99269e0062e9df1d...
==========

[commit-bot: I haz the power, 2017-01-10 05:00:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5157480667e99269e0062e9df1d...

[jonross, 2017-01-10 15:53:08]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2618383004/ by jonross@chromium.org.

The reason for reverting is: Hey,

The change in #15 has broken chromium os builds:

obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to
'ash::kWindowControlMinimizeIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to
'ash::kWindowControlCloseIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to
'ash::kWindowControlLeftSnappedIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to
'ash::kWindowControlRightSnappedIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to
'ash::kWindowControlRestoreIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to
'ash::kWindowControlMaximizeIcon'


The new icon constants are not checked in. I will revert to unblock the build..

[sky, 2017-01-10 16:13:26]

I wonder how the patch made it through the CQ. ash_unittests on
chromeos wouldn't compile for me. Maybe it only effected shared
library build?

On Tue, Jan 10, 2017 at 7:53 AM,  <jonross@chromium.org> wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2618383004/ by jonross@chromium.org.
>
> The reason for reverting is: Hey,
>
> The change in #15 has broken chromium os builds:
>
>
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
> BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference
> to
> 'ash::kWindowControlMinimizeIcon'
>
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
> BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference
> to
> 'ash::kWindowControlCloseIcon'
>
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
> BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference
> to
> 'ash::kWindowControlLeftSnappedIcon'
>
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
> BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference
> to
> 'ash::kWindowControlRightSnappedIcon'
>
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
> BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference
> to
> 'ash::kWindowControlRestoreIcon'
>
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function
> BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference
> to
> 'ash::kWindowControlMaximizeIcon'
>
>
> The new icon constants are not checked in. I will revert to unblock the
> build..
>
> https://codereview.chromium.org/2620613005/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Evan Stade, 2017-01-10 16:44:06]

On 2017/01/10 16:13:26, sky wrote:
> I wonder how the patch made it through the CQ. ash_unittests on
> chromeos wouldn't compile for me. Maybe it only effected shared
> library build?
> 

I'm guessing a missing dependency on the generated file(s) meant
non-deterministic compile failures.

[Evan Stade, 2017-01-10 16:47:14]

On 2017/01/10 16:44:06, Evan Stade wrote:
> On 2017/01/10 16:13:26, sky wrote:
> > I wonder how the patch made it through the CQ. ash_unittests on
> > chromeos wouldn't compile for me. Maybe it only effected shared
> > library build?
> > 
> 
> I'm guessing a missing dependency on the generated file(s) meant
> non-deterministic compile failures.

hmm, dependencies seem to be in order. Missing ASH_EXPORT?