3 years, 11 months ago
(2017-01-11 12:01:01 UTC)
#8
thanks!
dgn
https://codereview.chromium.org/2622793003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java (right): https://codereview.chromium.org/2622793003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java#newcode13 chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java:13: * have changed with an optional payload object On ...
3 years, 11 months ago
(2017-01-11 12:01:14 UTC)
#9
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98056)
3 years, 11 months ago
(2017-01-11 13:30:02 UTC)
#14
Will add tests separately, to cover also the offline feature in another patch.
3 years, 11 months ago
(2017-01-12 15:37:25 UTC)
#35
Will add tests separately, to cover also the offline feature in another patch.
commit-bot: I haz the power
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484235409787290, "parent_rev": "48c86fea4f973ef4eb12e61085ad9bfdd83996bf", "commit_rev": "be82572903bce4c189a2c23548343bd03c3af14a"}
3 years, 11 months ago
(2017-01-12 15:42:11 UTC)
#36
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484235409787290,
"parent_rev": "48c86fea4f973ef4eb12e61085ad9bfdd83996bf", "commit_rev":
"be82572903bce4c189a2c23548343bd03c3af14a"}
commit-bot: I haz the power
Description was changed from ========== [NTP Client] Implement offline badge refresh via partial bind The ...
3 years, 11 months ago
(2017-01-12 15:42:49 UTC)
#37
Message was sent while issue was closed.
Description was changed from
==========
[NTP Client] Implement offline badge refresh via partial bind
The RecyclerView library has a mechanism to perform partial refresh
of views from the adapter via partial binds[1]. Added support for it
in the NewTabPageAdapter and related classes, and rewrote the refresh
of the offline badge using that.
This patch also fixes an issue where the badge was not removed when an
offline page was deleted
Preview: https://goo.gl/photos/MKD2WXTiNqbQ17xD8
BUG=616090
==========
to
==========
[NTP Client] Implement offline badge refresh via partial bind
The RecyclerView library has a mechanism to perform partial refresh
of views from the adapter via partial binds[1]. Added support for it
in the NewTabPageAdapter and related classes, and rewrote the refresh
of the offline badge using that.
This patch also fixes an issue where the badge was not removed when an
offline page was deleted
Preview: https://goo.gl/photos/MKD2WXTiNqbQ17xD8
BUG=616090
Review-Url: https://codereview.chromium.org/2622793003
Cr-Commit-Position: refs/heads/master@{#443236}
Committed:
https://chromium.googlesource.com/chromium/src/+/be82572903bce4c189a2c2354834...
==========
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/be82572903bce4c189a2c23548343bd03c3af14a
3 years, 11 months ago
(2017-01-12 15:42:49 UTC)
#38
Issue 2622793003: 📰 Implement offline badge refresh via partial bind
(Closed)
Created 3 years, 11 months ago by dgn
Modified 3 years, 11 months ago
Reviewers: Michael van Ouwerkerk, Bernhard Bauer
Base URL:
Comments: 17