chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java - Issue 2622793003: 📰 Implement offline badge refresh via partial bind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

Issue 2622793003: 📰 Implement offline badge refresh via partial bind (Closed)

Patch Set: address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

index f54db9da5637255947a33701d2119168626456af..a638260718101b027de63959b9360d1f78d42d21 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

@@ -71,10 +71,10 @@ public int getItemViewType(int position) {

}

@Override

- public void onBindViewHolder(NewTabPageViewHolder holder, int position) {

+ public void onBindViewHolder(NewTabPageViewHolder holder, int position, List<Object> payloads) {

int index = getChildIndexForPosition(position);

mChildren.get(index).onBindViewHolder(

- holder, position - getStartingOffsetForChildIndex(index));

+ holder, position - getStartingOffsetForChildIndex(index), payloads);

}

@Override

@@ -99,8 +99,8 @@ public int getDismissSiblingPosDelta(int position) {

}

@Override

- public void onItemRangeChanged(TreeNode child, int index, int count) {

- notifyItemRangeChanged(getStartingOffsetForChild(child) + index, count);

+ public void onItemRangeChanged(TreeNode child, int index, int count, Object payload) {

+ notifyItemRangeChanged(getStartingOffsetForChild(child) + index, count, payload);

}

@Override