Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

Issue 2622793003: 📰 Implement offline badge refresh via partial bind (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
index 2ba0adc99f7535ab1598c06ed74e78e77962b02d..8217f763b42f1b3db209a730365ea9b2f6ce6828 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
@@ -30,6 +30,8 @@
import org.chromium.testing.local.LocalRobolectricTestRunner;
import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
/**
@@ -79,15 +81,17 @@ public void testGetItemViewType() {
@Test
public void testBindViewHolder() {
NewTabPageViewHolder holder = mock(NewTabPageViewHolder.class);
- mInnerNode.onBindViewHolder(holder, 0);
- mInnerNode.onBindViewHolder(holder, 5);
- mInnerNode.onBindViewHolder(holder, 6);
- mInnerNode.onBindViewHolder(holder, 11);
-
- verify(mChildren.get(0)).onBindViewHolder(holder, 0);
- verify(mChildren.get(2)).onBindViewHolder(holder, 2);
- verify(mChildren.get(4)).onBindViewHolder(holder, 0);
- verify(mChildren.get(6)).onBindViewHolder(holder, 0);
+ List<Object> payload1 = Collections.emptyList();
+ List<Object> payload2 = Arrays.<Object>asList("some data", "some other data");
+ mInnerNode.onBindViewHolder(holder, 0, payload1);
+ mInnerNode.onBindViewHolder(holder, 5, payload1);
+ mInnerNode.onBindViewHolder(holder, 6, payload2);
+ mInnerNode.onBindViewHolder(holder, 11, payload1);
+
+ verify(mChildren.get(0)).onBindViewHolder(holder, 0, payload1);
+ verify(mChildren.get(2)).onBindViewHolder(holder, 2, payload1);
+ verify(mChildren.get(4)).onBindViewHolder(holder, 0, payload2);
+ verify(mChildren.get(6)).onBindViewHolder(holder, 0, payload1);
}
@Test
@@ -147,13 +151,13 @@ public void testRemoveChild() {
@Test
public void testNotifications() {
mInnerNode.onItemRangeInserted(mChildren.get(0), 0, 23);
- mInnerNode.onItemRangeChanged(mChildren.get(2), 2, 9000);
- mInnerNode.onItemRangeChanged(mChildren.get(4), 0, 6502);
+ mInnerNode.onItemRangeChanged(mChildren.get(2), 2, 9000, null);
+ mInnerNode.onItemRangeChanged(mChildren.get(4), 0, 6502, null);
mInnerNode.onItemRangeRemoved(mChildren.get(6), 0, 8086);
verify(mParent).onItemRangeInserted(mInnerNode, 0, 23);
- verify(mParent).onItemRangeChanged(mInnerNode, 5, 9000);
- verify(mParent).onItemRangeChanged(mInnerNode, 6, 6502);
+ verify(mParent).onItemRangeChanged(mInnerNode, 5, 9000, null);
+ verify(mParent).onItemRangeChanged(mInnerNode, 6, 6502, null);
verify(mParent).onItemRangeRemoved(mInnerNode, 11, 8086);
}
@@ -203,7 +207,7 @@ public void expectItemCount(int count) {
}
@Override
- public void onItemRangeChanged(TreeNode child, int index, int count) {
+ public void onItemRangeChanged(TreeNode child, int index, int count, Object payload) {
checkCount(child);
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698