Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2622413004: [runtime] Remove further usages of PropertyType in favor of PropertyKind/PropertyLocation. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove further usages of PropertyType in favor of PropertyKind/PropertyLocation. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2622413004 Cr-Commit-Position: refs/heads/master@{#42328} Committed: https://chromium.googlesource.com/v8/v8/+/d4363986d70efd6f6f4f404afacf3fcde6532b6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -58 lines) Patch
M src/api-natives.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 8 chunks +10 lines, -11 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M src/objects.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/property.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/property.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/property-details.h View 2 chunks +6 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-12 16:45:05 UTC) #4
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-13 12:57:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622413004/20001
3 years, 11 months ago (2017-01-13 13:14:59 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:17:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d4363986d70efd6f6f4f404afacf3fcde65...

Powered by Google App Engine
This is Rietveld 408576698