Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: src/property-details.h

Issue 2622413004: [runtime] Remove further usages of PropertyType in favor of PropertyKind/PropertyLocation. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property-details.h
diff --git a/src/property-details.h b/src/property-details.h
index 1d096202d03ee7871ef0cc33beb1df574780e311..02354b89babc79616f0733b944b4ec3ca3f14e25 100644
--- a/src/property-details.h
+++ b/src/property-details.h
@@ -232,26 +232,16 @@ enum class PropertyCellConstantType {
// They are used both in property dictionaries and instance descriptors.
class PropertyDetails BASE_EMBEDDED {
public:
- PropertyDetails(PropertyAttributes attributes, PropertyType type, int index,
+ // Property details for dictionary mode properties/elements.
+ PropertyDetails(PropertyKind kind, PropertyAttributes attributes, int index,
PropertyCellType cell_type) {
- value_ = TypeField::encode(type) | AttributesField::encode(attributes) |
+ value_ = KindField::encode(kind) | LocationField::encode(kField) |
+ AttributesField::encode(attributes) |
DictionaryStorageField::encode(index) |
PropertyCellTypeField::encode(cell_type);
-
- DCHECK(type == this->type());
- DCHECK(attributes == this->attributes());
- }
-
- PropertyDetails(PropertyAttributes attributes,
- PropertyType type,
- Representation representation,
- int field_index = 0) {
- value_ = TypeField::encode(type)
- | AttributesField::encode(attributes)
- | RepresentationField::encode(EncodeRepresentation(representation))
- | FieldIndexField::encode(field_index);
}
+ // Property details for fast mode properties.
PropertyDetails(PropertyKind kind, PropertyAttributes attributes,
PropertyLocation location, Representation representation,
int field_index = 0) {
@@ -263,7 +253,7 @@ class PropertyDetails BASE_EMBEDDED {
static PropertyDetails Empty(
PropertyCellType cell_type = PropertyCellType::kNoCell) {
- return PropertyDetails(NONE, DATA, 0, cell_type);
+ return PropertyDetails(kData, NONE, 0, cell_type);
}
int pointer() const { return DescriptorPointer::decode(value_); }
« no previous file with comments | « src/property.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698