Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2633553002: [runtime] Cleanup DescriptorArray interface, remove more PropertyType usages. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Cleanup DescriptorArray interface, remove more PropertyType usages. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2633553002 Cr-Commit-Position: refs/heads/master@{#42329} Committed: https://chromium.googlesource.com/v8/v8/+/4caeb1e9eb306ca88886193edf5a4ae9db31c37a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -85 lines) Patch
M src/bootstrapper.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/objects.cc View 6 chunks +12 lines, -36 lines 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -35 lines 0 comments Download
M src/property-descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-13 12:07:25 UTC) #7
Jakob Kummerow
LGTM, nice!
3 years, 11 months ago (2017-01-13 13:02:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633553002/20001
3 years, 11 months ago (2017-01-13 13:21:50 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:23:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4caeb1e9eb306ca88886193edf5a4ae9db3...

Powered by Google App Engine
This is Rietveld 408576698