Generalize browser controls adjustment for arbitrary scrollers.

Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2622103002
Cr-Commit-Position: refs/heads/master@{#443079}
Committed: https://chromium.googlesource.com/chromium/src/+/eea21c858d184a593903840cbaaa08339f6ac603

[bokan, 2017-01-11 01:41:17]

Description was changed from

==========
Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use
to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
==========

to

==========
Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use
to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[bokan, 2017-01-11 01:41:39]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 01:42:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:15:12]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-01-11 13:29:15]

Description was changed from

==========
Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use
to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use
to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[bokan, 2017-01-11 13:29:15]

bokan@chromium.org changed reviewers:
+ skobes@chromium.org

[bokan, 2017-01-11 13:29:26]

ptal

[bokan, 2017-01-11 13:37:13]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 13:37:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:16:34]

Dry run: This issue passed the CQ dry run.

[skobes, 2017-01-12 00:03:58]

lgtm

[bokan, 2017-01-12 00:11:05]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:12:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:26:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484179865503000,
"parent_rev": "2ad11d9a384d881c1ea962e4bcc6a269b7781259", "commit_rev":
"eea21c858d184a593903840cbaaa08339f6ac603"}

[commit-bot: I haz the power, 2017-01-12 00:27:12]

Description was changed from

==========
Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use
to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Generalize browser controls adjustment for arbitrary scrollers.

When the browser controls (URL bar) are hidden/shown, they change the visible
area of the viewport, allowing more or less scrolling. Until a resize occurs and
the FrameView/LayoutView is resized, we keep an "adjustment" value that we use
to
fudge the maximumScrollOffset in the interim.

When a scroller is set as the document.rootScroller, we want it to behave in
the same way. This patch extends the behavior to all FrameViews and
PaintLayerScrollableAreas when they become the global root scroller. The
adjustment value is no longer stored in the FrameView. Instead,
TopDocumentRootScrollerController uses the value stored in VisualViewport to
calculate the current visible area of the viewport.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2622103002
Cr-Commit-Position: refs/heads/master@{#443079}
Committed:
https://chromium.googlesource.com/chromium/src/+/eea21c858d184a593903840cbaaa...
==========

[commit-bot: I haz the power, 2017-01-12 00:27:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eea21c858d184a593903840cbaaa...