Generalize browser controls adjustment for arbitrary scrollers.

third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ClientRect.h"
 #include "core/frame/BrowserControls.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/RootFrameViewport.h"
 #include "core/frame/VisualViewport.h"
@@ skipping 40 matching lines @@
   }
 
   ~RootScrollerTest() override {
     m_featuresBackup.restore();
     Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
     WebCache::clear();
   }
 
   WebViewImpl* initialize(const std::string& pageName,
                           FrameTestHelpers::TestWebViewClient* client) {
-    RuntimeEnabledFeatures::setSetRootScrollerEnabled(true);
-
-    m_helper.initializeAndLoad(m_baseURL + pageName, true, nullptr, client,
-                               nullptr, &configureSettings);
-
-    // Initialize browser controls to be shown.
-    webViewImpl()->resizeWithBrowserControls(IntSize(400, 400), 50, true);
-    webViewImpl()->browserControls().setShownRatio(1);
-
-    mainFrameView()->updateAllLifecyclePhases();
-
-    return webViewImpl();
+    return initializeInternal(m_baseURL + pageName, client);
   }
 
   WebViewImpl* initialize(const std::string& pageName) {
-    return initialize(pageName, &m_client);
+    return initializeInternal(m_baseURL + pageName, &m_client);
+  }
+
+  WebViewImpl* initialize() {
+    return initializeInternal("about:blank", &m_client);
   }
 
   static void configureSettings(WebSettings* settings) {
     settings->setJavaScriptEnabled(true);
     settings->setAcceleratedCompositingEnabled(true);
     settings->setPreferCompositingToLCDTextEnabled(true);
     // Android settings.
     settings->setViewportEnabled(true);
     settings->setViewportMetaEnabled(true);
     settings->setShrinksViewportContentToFit(true);
@@ skipping 67 matching lines @@
     event.sourceDevice = device;
     event.x = 100;
     event.y = 100;
     if (type == WebInputEvent::GestureScrollUpdate) {
       event.data.scrollUpdate.deltaX = deltaX;
       event.data.scrollUpdate.deltaY = deltaY;
     }
     return event;
   }
 
+  WebViewImpl* initializeInternal(const std::string& url,
+                                  FrameTestHelpers::TestWebViewClient* client) {
+    RuntimeEnabledFeatures::setSetRootScrollerEnabled(true);
+
+    m_helper.initializeAndLoad(url, true, nullptr, client, nullptr,
+                               &configureSettings);
+
+    // Initialize browser controls to be shown.
+    webViewImpl()->resizeWithBrowserControls(IntSize(400, 400), 50, true);
+    webViewImpl()->browserControls().setShownRatio(1);
+
+    mainFrameView()->updateAllLifecyclePhases();
+
+    return webViewImpl();
+  }
+
   std::string m_baseURL;
   FrameTestHelpers::TestWebViewClient m_client;
   FrameTestHelpers::WebViewHelper m_helper;
   RuntimeEnabledFeatures::Backup m_featuresBackup;
 };
 
 // Test that no root scroller element is set if setRootScroller isn't called on
 // any elements. The document Node should be the default effective root
 // scroller.
 TEST_F(RootScrollerTest, TestDefaultRootScroller) {
@@ skipping 48 matching lines @@
 // bar hiding and overscroll.
 TEST_F(RootScrollerTest, TestSetRootScroller) {
   OverscrollTestWebViewClient client;
   initialize("root-scroller.html", &client);
 
   Element* container = mainFrame()->document()->getElementById("container");
   DummyExceptionStateForTesting exceptionState;
   mainFrame()->document()->setRootScroller(container, exceptionState);
   ASSERT_EQ(container, mainFrame()->document()->rootScroller());
 
-  // Content is 1000x1000, WebView size is 400x400 so max scroll is 600px.
-  double maximumScroll = 600;
+  // Content is 1000x1000, WebView size is 400x400 but hiding the top controls
+  // makes it 400x450 so max scroll is 550px.
+  double maximumScroll = 550;
 
   webViewImpl()->handleInputEvent(
       generateTouchGestureEvent(WebInputEvent::GestureScrollBegin));
 
   {
     // Scrolling over the #container DIV should cause the browser controls to
     // hide.
     EXPECT_FLOAT_EQ(1, browserControls().shownRatio());
     webViewImpl()->handleInputEvent(generateTouchGestureEvent(
         WebInputEvent::GestureScrollUpdate, 0, -browserControls().height()));
     EXPECT_FLOAT_EQ(0, browserControls().shownRatio());
   }
 
   {
     // Make sure we're actually scrolling the DIV and not the FrameView.
     webViewImpl()->handleInputEvent(
         generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -100));
     EXPECT_FLOAT_EQ(100, container->scrollTop());
     EXPECT_FLOAT_EQ(0, mainFrameView()->getScrollOffset().height());
   }
 
   {
     // Scroll 50 pixels past the end. Ensure we report the 50 pixels as
     // overscroll.
     EXPECT_CALL(client, didOverscroll(WebFloatSize(0, 50), WebFloatSize(0, 50),
                                       WebFloatPoint(100, 100), WebFloatSize()));
     webViewImpl()->handleInputEvent(
-        generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -550));
+        generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -500));
     EXPECT_FLOAT_EQ(maximumScroll, container->scrollTop());
     EXPECT_FLOAT_EQ(0, mainFrameView()->getScrollOffset().height());
     Mock::VerifyAndClearExpectations(&client);
   }
 
   {
     // Continue the gesture overscroll.
     EXPECT_CALL(client, didOverscroll(WebFloatSize(0, 20), WebFloatSize(0, 70),
                                       WebFloatPoint(100, 100), WebFloatSize()));
     webViewImpl()->handleInputEvent(
@@ skipping 866 matching lines @@
   mainFrameView()->updateAllLifecyclePhases();
 
   ScrollableArea* containerScroller = childFrame->view();
 
   EXPECT_FALSE(containerScroller->horizontalScrollbar());
   EXPECT_FALSE(containerScroller->verticalScrollbar());
   EXPECT_GT(containerScroller->maximumScrollOffset().width(), 0);
   EXPECT_GT(containerScroller->maximumScrollOffset().height(), 0);
 }
 
+TEST_F(RootScrollerTest, TopControlsAdjustmentAppliedToRootScroller) {
+  initialize();
+
+  WebURL baseURL = URLTestHelpers::toKURL("http://www.test.com/");
+  FrameTestHelpers::loadHTMLString(webViewImpl()->mainFrame(),
+                                   "<!DOCTYPE html>"
+                                   "<style>"
+                                   "  body, html {"
+                                   "    width: 100%;"
+                                   "    height: 100%;"
+                                   "    margin: 0px;"
+                                   "  }"
+                                   "  #container {"
+                                   "    width: 100%;"
+                                   "    height: 100%;"
+                                   "    overflow: auto;"
+                                   "  }"
+                                   "</style>"
+                                   "<div id='container'>"
+                                   "  <div style='height:1000px'>test</div>"
+                                   "</div>",
+                                   baseURL);
+
+  webViewImpl()->resizeWithBrowserControls(IntSize(400, 400), 50, true);
+  mainFrameView()->updateAllLifecyclePhases();
+
+  Element* container = mainFrame()->document()->getElementById("container");
+  mainFrame()->document()->setRootScroller(container, ASSERT_NO_EXCEPTION);
+
+  ScrollableArea* containerScroller =
+      static_cast<PaintInvalidationCapableScrollableArea*>(
+          toLayoutBox(container->layoutObject())->getScrollableArea());
+
+  // Hide the top controls and scroll down maximally. We should account for the
+  // change in maximum scroll offset due to the top controls hiding. That is,
+  // since the controls are hidden, the "content area" is taller so the maximum
+  // scroll offset should shrink.
+  ASSERT_EQ(1000 - 400, containerScroller->maximumScrollOffset().height());
+
+  webViewImpl()->handleInputEvent(
+      generateTouchGestureEvent(WebInputEvent::GestureScrollBegin));
+  ASSERT_EQ(1, browserControls().shownRatio());
+  webViewImpl()->handleInputEvent(generateTouchGestureEvent(
+      WebInputEvent::GestureScrollUpdate, 0, -browserControls().height()));
+  ASSERT_EQ(0, browserControls().shownRatio());
+  EXPECT_EQ(1000 - 450, containerScroller->maximumScrollOffset().height());
+
+  webViewImpl()->handleInputEvent(
+      generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -3000));
+  EXPECT_EQ(1000 - 450, containerScroller->getScrollOffset().height());
+
+  webViewImpl()->handleInputEvent(
+      generateTouchGestureEvent(WebInputEvent::GestureScrollEnd));
+  webViewImpl()->resizeWithBrowserControls(IntSize(400, 450), 50, false);
+  EXPECT_EQ(1000 - 450, containerScroller->maximumScrollOffset().height());
+}
+
 TEST_F(RootScrollerTest, RotationAnchoring) {
   initialize("root-scroller-rotation.html");
 
   ScrollableArea* containerScroller;
 
   {
     webViewImpl()->resizeWithBrowserControls(IntSize(250, 1000), 0, true);
     mainFrameView()->updateAllLifecyclePhases();
 
     Element* container = mainFrame()->document()->getElementById("container");
@@ skipping 87 matching lines @@
   // FrameView without a layout.
   iframe->remove();
 
   EXPECT_EQ(mainFrameView()->layoutViewportScrollableArea(),
             &mainFrameView()->getRootFrameViewport()->layoutViewport());
 }
 
 }  // namespace
 
 }  // namespace blink