Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2622103002: Generalize browser controls adjustment for arbitrary scrollers. (Closed)
Patch Set: Fixed some comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 113edd6642cab177ad56db78ba5a7a78c31a9432..7d3c47cde10a4c24e4684c3f94a0fa24f7042cb6 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -1846,11 +1846,6 @@ void WebViewImpl::didUpdateBrowserControls() {
browserControls().layoutHeight() - browserControls().contentOffset();
visualViewport.setBrowserControlsAdjustment(
browserControlsViewportAdjustment);
-
- // Since the FrameView is sized to be the visual viewport at minimum
- // scale, its adjustment must also be scaled by the minimum scale.
- view->setBrowserControlsViewportAdjustment(
- browserControlsViewportAdjustment / minimumPageScaleFactor());
}
}

Powered by Google App Engine
This is Rietveld 408576698