Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2622243003: The great shader refactor: Clean up GLRenderer (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The great shader refactor: Clean up GLRenderer Get rid of the functions to get each individual program type, and replace them with calls to GetProgram with the appropriate key. Move uniform tracking to ProgramBinding, and get rid of all of the various "uniform cache" structures that were created to handle getting uniforms from all of the different shader types. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -666 lines) Patch
M cc/output/gl_renderer.h View 1 2 chunks +2 lines, -100 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 28 chunks +117 lines, -446 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 3 chunks +44 lines, -32 lines 0 comments Download
M cc/output/program_binding.h View 1 chunk +59 lines, -0 lines 0 comments Download
M cc/output/shader.h View 3 chunks +0 lines, -50 lines 0 comments Download
M cc/output/shader.cc View 3 chunks +0 lines, -38 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (18 generated)
ccameron
ptal -- more salami slices
3 years, 11 months ago (2017-01-12 09:27:14 UTC) #8
enne (OOO)
Ahhh this patch is so great. lgtm
3 years, 11 months ago (2017-01-12 18:30:36 UTC) #10
ccameron
:D
3 years, 11 months ago (2017-01-12 22:20:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622243003/20001
3 years, 11 months ago (2017-01-12 22:21:03 UTC) #18
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-12 22:38:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622243003/20001
3 years, 11 months ago (2017-01-13 07:37:01 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/341479)
3 years, 11 months ago (2017-01-13 07:43:01 UTC) #25
ccameron
3 years, 11 months ago (2017-01-13 21:34:07 UTC) #26
On 2017/01/13 07:43:01, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Oh I am so confused ... this looks like it landed, but there's no commit
message.

Whelp, it's in the tree, that's good enough for me.

Powered by Google App Engine
This is Rietveld 408576698