rewrite_to_chrome_style: Make is-const decisions more consistent

rewrite_to_chrome_style: Make is-const decisions more consistent

This fixes cases where a templated method accesses a member on its
class object, and cases where a function argument is templated and
used as the input to a const variable.

R=dcheng@chromium.org
BUG=677285
Review-Url: https://codereview.chromium.org/2622003002
Cr-Commit-Position: refs/heads/master@{#442936}
Committed: https://chromium.googlesource.com/chromium/src/+/5e2c34d46083dc28796e3e68e34b2b8231a8c5cc

[danakj, 2017-01-10 21:00:18]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-10 21:01:29]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:01:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:19:47]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-01-11 00:32:07]

How strongly do you feel about keeping the debug logging?

[danakj, 2017-01-11 15:55:47]

On 2017/01/11 00:32:07, dcheng wrote:
> How strongly do you feel about keeping the debug logging?

Eh, I can remove it if you want. I just keep having to re-add it as I continue
to diagnose cases and it didn't seem harmful.

[danakj, 2017-01-11 16:23:50]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2017-01-11 16:23:53]

Heres without printing code

[commit-bot: I haz the power, 2017-01-11 16:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:35:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:35:17]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-01-11 17:03:12]

LGTM.

FWIW, I think I'd be OK with the printing code if we guarded it with a define
that we can toggle at the top of the file. It's just a bit hard to visually
distinguish for me otherwise.

https://codereview.chromium.org/2622003002/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2622003002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:412: if
(clang::dyn_cast<clang::VarDecl>(decl))
Nit: use isa... except I guess the followup CL changes this to use the result of
the dyn_cast, so never mind =)

[danakj, 2017-01-11 17:03:41]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-01-11 17:03:58]

On 2017/01/11 17:03:12, dcheng wrote:
> LGTM.
> 
> FWIW, I think I'd be OK with the printing code if we guarded it with a define
> that we can toggle at the top of the file. It's just a bit hard to visually
> distinguish for me otherwise.

o ok maybe in a future CL :3 this has green bots

> 
>
https://codereview.chromium.org/2622003002/diff/40001/tools/clang/rewrite_to_...
> File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):
> 
>
https://codereview.chromium.org/2622003002/diff/40001/tools/clang/rewrite_to_...
> tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:412: if
> (clang::dyn_cast<clang::VarDecl>(decl))
> Nit: use isa... except I guess the followup CL changes this to use the result
of
> the dyn_cast, so never mind =)

[commit-bot: I haz the power, 2017-01-11 17:04:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:07:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484154221226540,
"parent_rev": "fbf7d2f274233a8a680edc162aa642cf0f9a7d9f", "commit_rev":
"5e2c34d46083dc28796e3e68e34b2b8231a8c5cc"}

[commit-bot: I haz the power, 2017-01-11 17:08:40]

Description was changed from

==========
rewrite_to_chrome_style: Make is-const decisions more consistent

This fixes cases where a templated method accesses a member on its
class object, and cases where a function argument is templated and
used as the input to a const variable.

R=dcheng@chromium.org
BUG=677285
==========

to

==========
rewrite_to_chrome_style: Make is-const decisions more consistent

This fixes cases where a templated method accesses a member on its
class object, and cases where a function argument is templated and
used as the input to a const variable.

R=dcheng@chromium.org
BUG=677285

Review-Url: https://codereview.chromium.org/2622003002
Cr-Commit-Position: refs/heads/master@{#442936}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e2c34d46083dc28796e3e68e34b...
==========

[commit-bot: I haz the power, 2017-01-11 17:08:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5e2c34d46083dc28796e3e68e34b...