rewrite_to_chrome_style: Make is-const decisions more consistent

tools/clang/rewrite_to_chrome_style/tests/template-original.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <type_traits>
 
 namespace not_blink {
 
 void function(int x) {}
 
@@ skipping 57 matching lines @@
 template <int number, typename... T>
 void F() {
   // These are const but hacker_case so we leave them alone.
   const int maybe_a_const = sizeof...(T);
   const int is_a_const = number;
   // These are const expressions so they get a k prefix.
   const int maybeAConstToo = sizeof...(T);
   const int isAConstToo = number;
 }
 
+namespace test_member_in_template {
+
+template <typename T>
+class HasAMember {
+ public:
+  HasAMember() {}
+  HasAMember(const T&) {}
+
+  void usesMember() { const int notConst = m_i; }
+  void alsoUsesMember();
+
+ private:
+  int m_i;
+};
+
+template <typename T>
+void HasAMember<T>::alsoUsesMember() {
+  const int notConst = m_i;
+}
+
+template <typename T>
+static void basedOnSubType(const HasAMember<T>& t) {
+  const HasAMember<T> problematicNotConst(t);
+}
+
+void Run() {
+  HasAMember<int>().usesMember();
+
+  basedOnSubType<int>(HasAMember<int>());
+  enum E { A };
+  basedOnSubType<E>(HasAMember<E>());
+}
+}
+
 namespace test_template_arg_is_function {
 
 void f(int x) {}
 
 template <typename T, void g(T)>
 void h(T x) {
   g(x);
 }
 
 void test() {
@@ skipping 246 matching lines @@
     // Need to rewrite |f| to |F| below (because this method name
     // does get rewritten when processing blink::test_unnamed_arg::Class).
     // See also https://crbug.com/670434.
     output->f(123);
   }
 };
 
 }  // namespace blink_methods_called_from_mojo_traits_are_not_rewritten
 
 }  // namespace not_blink