Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2624253002: rewrite_to_chrome_style: Make const decisions aware of const variables (Closed)

Created:
3 years, 11 months ago by danakj
Modified:
3 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Make const decisions aware of const variables When a const variable is initialized by another variable, we recurse to see if that variable is compile-time-const to decide if the former variable is. BUG=677285 Review-Url: https://codereview.chromium.org/2624253002 Cr-Commit-Position: refs/heads/master@{#442938} Committed: https://chromium.googlesource.com/chromium/src/+/ed3c975463926a72676db3793bdbed76926086b0

Patch Set 1 : consistent-consts-3: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/template-expected.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/template-original.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
danakj
3 years, 11 months ago (2017-01-11 16:41:44 UTC) #3
dcheng
LGTM
3 years, 11 months ago (2017-01-11 17:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624253002/1
3 years, 11 months ago (2017-01-11 17:09:20 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 17:14:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed3c975463926a72676db3793bdb...

Powered by Google App Engine
This is Rietveld 408576698