Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2621923002: Product cleanups in the wake of multi-install removal. (Closed)

Created:
3 years, 11 months ago by grt (UTC plus 2)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Product cleanups in the wake of multi-install removal. - Remove |options| set. - Remove InitializeFrom* methods. - Remove unused SetChannelFlags method. BUG=577816 Review-Url: https://codereview.chromium.org/2621923002 Cr-Commit-Position: refs/heads/master@{#442870} Committed: https://chromium.googlesource.com/chromium/src/+/d67aff2c0a31ffeb9db2112b30fd043847dba9ee

Patch Set 1 #

Patch Set 2 : sync to position 442831 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -192 lines) Patch
M chrome/installer/setup/installer_state.cc View 4 chunks +1 line, -4 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.h View 3 chunks +3 lines, -18 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.cc View 2 chunks +1 line, -66 lines 0 comments Download
M chrome/installer/util/chrome_browser_sxs_operations.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/installer/util/chrome_browser_sxs_operations.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/product.h View 1 5 chunks +0 lines, -25 lines 0 comments Download
M chrome/installer/util/product.cc View 1 4 chunks +4 lines, -21 lines 0 comments Download
M chrome/installer/util/product_operations.h View 3 chunks +9 lines, -34 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (14 generated)
Sébastien Marchand
lgtm! Always happy to see some code get removed!
3 years, 11 months ago (2017-01-10 18:38:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621923002/40001
3 years, 11 months ago (2017-01-11 11:19:54 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 11:24:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d67aff2c0a31ffeb9db2112b30fd...

Powered by Google App Engine
This is Rietveld 408576698