Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2133)

Unified Diff: chrome/installer/util/product.cc

Issue 2621923002: Product cleanups in the wake of multi-install removal. (Closed)
Patch Set: sync to position 442831 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/product.h ('k') | chrome/installer/util/product_operations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/product.cc
diff --git a/chrome/installer/util/product.cc b/chrome/installer/util/product.cc
index 22cd9292babbef819a47484266adb3ef4d375d90..6d6c55c4d45170c6ede33eb653e242880c07b99c 100644
--- a/chrome/installer/util/product.cc
+++ b/chrome/installer/util/product.cc
@@ -15,12 +15,9 @@
#include "chrome/installer/util/chrome_browser_sxs_operations.h"
#include "chrome/installer/util/google_update_constants.h"
#include "chrome/installer/util/install_util.h"
-#include "chrome/installer/util/master_preferences.h"
-#include "chrome/installer/util/master_preferences_constants.h"
#include "chrome/installer/util/product_operations.h"
using base::win::RegKey;
-using installer::MasterPreferences;
namespace installer {
@@ -33,15 +30,6 @@ Product::Product(BrowserDistribution* distribution)
Product::~Product() {
}
-void Product::InitializeFromPreferences(const MasterPreferences& prefs) {
- operations_->ReadOptions(prefs, &options_);
-}
-
-void Product::InitializeFromUninstallCommand(
- const base::CommandLine& uninstall_command) {
- operations_->ReadOptions(uninstall_command, &options_);
-}
-
bool Product::LaunchChrome(const base::FilePath& application_path) const {
bool success = !application_path.empty();
if (success) {
@@ -112,19 +100,15 @@ bool Product::SetMsiMarker(bool system_install, bool set) const {
}
void Product::AddKeyFiles(std::vector<base::FilePath>* key_files) const {
- operations_->AddKeyFiles(options_, key_files);
+ operations_->AddKeyFiles(key_files);
}
void Product::AppendProductFlags(base::CommandLine* command_line) const {
- operations_->AppendProductFlags(options_, command_line);
+ operations_->AppendProductFlags(command_line);
}
void Product::AppendRenameFlags(base::CommandLine* command_line) const {
- operations_->AppendRenameFlags(options_, command_line);
-}
-
-bool Product::SetChannelFlags(bool set, ChannelInfo* channel_info) const {
- return operations_->SetChannelFlags(options_, set, channel_info);
+ operations_->AppendRenameFlags(command_line);
}
void Product::AddDefaultShortcutProperties(
@@ -141,8 +125,7 @@ void Product::LaunchUserExperiment(const base::FilePath& setup_path,
VLOG(1) << "LaunchUserExperiment status: " << status << " product: "
<< distribution_->GetDisplayName()
<< " system_level: " << system_level;
- operations_->LaunchUserExperiment(
- setup_path, options_, status, system_level);
+ operations_->LaunchUserExperiment(setup_path, status, system_level);
}
}
« no previous file with comments | « chrome/installer/util/product.h ('k') | chrome/installer/util/product_operations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698