Remove BrowserDistribution::Type.

Remove BrowserDistribution::Type.

BUG=577816
Review-Url: https://codereview.chromium.org/2622883002
Cr-Commit-Position: refs/heads/master@{#442868}
Committed: https://chromium.googlesource.com/chromium/src/+/0c41dc8e878a12a5a3a5bbbb77554c8fc60b28dd

[grt (UTC plus 2), 2017-01-10 11:03:11]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 11:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 11:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 11:05:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[fdoray, 2017-01-10 14:22:48]

Description was changed from

==========
Remove BrowserDistribution::Type.

BUG=577816
==========

to

==========
Remove BrowserDistribution::Type.

BUG=577816
==========

[fdoray, 2017-01-10 14:22:48]

fdoray@chromium.org changed reviewers:
+ fdoray@chromium.org

[fdoray, 2017-01-10 15:07:37]

lgtm

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/googl...
File chrome/installer/util/google_chrome_distribution.cc (right):

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/googl...
chrome/installer/util/google_chrome_distribution.cc:14: #include <memory>
This include should be in chrome/installer/util/google_chrome_distribution.h
because std::unique_ptr is used here
https://cs.chromium.org/chromium/src/chrome/installer/util/google_chrome_dist...

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/googl...
chrome/installer/util/google_chrome_distribution.cc:99: :
BrowserDistribution(std::unique_ptr<AppRegistrationData>(
MakeUnique<UpdatingAppRegistrationData>(kChromeGuid)?

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/insta...
File chrome/installer/util/install_util_unittest.cc (right):

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/insta...
chrome/installer/util/install_util_unittest.cc:42: :
BrowserDistribution(std::unique_ptr<AppRegistrationData>(
MakeUnique<TestAppRegistrationData>()?

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/produ...
File chrome/installer/util/product.h (right):

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/produ...
chrome/installer/util/product.h:16: #include
"chrome/installer/util/browser_distribution.h"
Can now be forward-declared.

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/produ...
chrome/installer/util/product.h:112: std::unique_ptr<ProductOperations>
operations_;
const std::unique_ptr<ProductOperations> operations_;

[grt (UTC plus 2), 2017-01-11 08:17:34]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-01-11 08:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org
Link to the patchset: https://codereview.chromium.org/2622883002/#ps40001
(title: "fdoray comments")

[commit-bot: I haz the power, 2017-01-11 08:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-01-11 08:17:55]

Thanks!

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/googl...
File chrome/installer/util/google_chrome_distribution.cc (right):

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/googl...
chrome/installer/util/google_chrome_distribution.cc:14: #include <memory>
On 2017/01/10 15:07:37, fdoray wrote:
> This include should be in chrome/installer/util/google_chrome_distribution.h
> because std::unique_ptr is used here
>
https://cs.chromium.org/chromium/src/chrome/installer/util/google_chrome_dist...

Done.

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/googl...
chrome/installer/util/google_chrome_distribution.cc:99: :
BrowserDistribution(std::unique_ptr<AppRegistrationData>(
On 2017/01/10 15:07:37, fdoray wrote:
> MakeUnique<UpdatingAppRegistrationData>(kChromeGuid)?

Done.

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/insta...
File chrome/installer/util/install_util_unittest.cc (right):

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/insta...
chrome/installer/util/install_util_unittest.cc:42: :
BrowserDistribution(std::unique_ptr<AppRegistrationData>(
On 2017/01/10 15:07:37, fdoray wrote:
> MakeUnique<TestAppRegistrationData>()?

Done.

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/produ...
File chrome/installer/util/product.h (right):

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/produ...
chrome/installer/util/product.h:16: #include
"chrome/installer/util/browser_distribution.h"
On 2017/01/10 15:07:37, fdoray wrote:
> Can now be forward-declared.

Done.

https://codereview.chromium.org/2622883002/diff/1/chrome/installer/util/produ...
chrome/installer/util/product.h:112: std::unique_ptr<ProductOperations>
operations_;
On 2017/01/10 15:07:37, fdoray wrote:
> const std::unique_ptr<ProductOperations> operations_;

Done.

[commit-bot: I haz the power, 2017-01-11 08:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:23:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2017-01-11 08:23:24]

grt@chromium.org changed reviewers:
+ jochen@chromium.org, vasilii@chromium.org

[grt (UTC plus 2), 2017-01-11 08:23:24]

OWNERS reviews please:

jochen: chrome/common/metrics_constants_util_win.cc
vasilii: chrome/browser/profile_resetter/profile_resetter.cc

Thanks!

[vasilii, 2017-01-11 09:24:37]

lgtm

chrome/browser/profile_resetter/profile_resetter.cc

[jochen (gone - plz use gerrit), 2017-01-11 09:56:50]

lgtm

[grt (UTC plus 2), 2017-01-11 11:05:20]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2017-01-11 11:05:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 11:09:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484132720729830,
"parent_rev": "facc326c5c6b19ab36e529ed8e2713c794901fe4", "commit_rev":
"0c41dc8e878a12a5a3a5bbbb77554c8fc60b28dd"}

[commit-bot: I haz the power, 2017-01-11 11:10:05]

Description was changed from

==========
Remove BrowserDistribution::Type.

BUG=577816
==========

to

==========
Remove BrowserDistribution::Type.

BUG=577816

Review-Url: https://codereview.chromium.org/2622883002
Cr-Commit-Position: refs/heads/master@{#442868}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c41dc8e878a12a5a3a5bbbb7755...
==========

[commit-bot: I haz the power, 2017-01-11 11:10:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c41dc8e878a12a5a3a5bbbb7755...