Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2621763002: Drop MSVC pch warning avoidance. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop MSVC pch warning avoidance. Unable to reproduce the warning with VS2015; let's try to remove this special case. R= BUG= Review-Url: https://codereview.chromium.org/2621763002 Cr-Commit-Position: refs/heads/master@{#442368} Committed: https://chromium.googlesource.com/chromium/src/+/f597e54c83b4da65da721b69e02ebd26ed181f92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M third_party/WebKit/Source/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sof
please take a look. been running with this off for a while + followed the ...
3 years, 11 months ago (2017-01-09 19:49:27 UTC) #2
Nico
lgtm
3 years, 11 months ago (2017-01-09 19:56:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621763002/1
3 years, 11 months ago (2017-01-09 19:57:34 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:20:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f597e54c83b4da65da721b69e02e...

Powered by Google App Engine
This is Rietveld 408576698