Chromium Code Reviews

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2621763002: Drop MSVC pch warning avoidance. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « third_party/WebKit/Source/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 8bb5ecce26026900063f10658ea7de531ea9604e..b6e4985195c3df6891acd159959525ae7f2a2155 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -66,17 +66,6 @@ config("blink_core_pch") {
# Force include the header.
cflags = [ "/FI$precompiled_header" ]
-
- # Disable warning for "this file was empty after preprocessing". This
- # error is generated only in C mode for ANSI compatibility. It conflicts
- # with precompiled headers since the source file that's "compiled" for
- # making the precompiled header is empty.
- #
- # This error doesn't happen every time. In VS2013, it seems if the .pch
- # file doesn't exist, no error will be generated (probably MS tested this
- # case but forgot the other one?). To reproduce this error, do a build,
- # then delete the precompile.c.obj file, then build again.
- cflags_c = [ "/wd4206" ]
}
}
}
« no previous file with comments | « third_party/WebKit/Source/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine