Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/WebKit/Source/BUILD.gn

Issue 2621763002: Drop MSVC pch warning avoidance. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/BUILD.gn
diff --git a/third_party/WebKit/Source/BUILD.gn b/third_party/WebKit/Source/BUILD.gn
index f862546e93afbd93ad0ebc2f617a093088d6cc56..ca5d37ceb669962f2b942391e9c90c4b2f0c26aa 100644
--- a/third_party/WebKit/Source/BUILD.gn
+++ b/third_party/WebKit/Source/BUILD.gn
@@ -69,17 +69,6 @@ config("blink_pch") {
# Force include the header.
cflags = [ "/FI$precompiled_header" ]
-
- # Disable warning for "this file was empty after preprocessing". This
- # error is generated only in C mode for ANSI compatibility. It conflicts
- # with precompiled headers since the source file that's "compiled" for
- # making the precompiled header is empty.
- #
- # This error doesn't happen every time. In VS2013, it seems if the .pch
- # file doesn't exist, no error will be generated (probably MS tested this
- # case but forgot the other one?). To reproduce this error, do a build,
- # then delete the precompile.c.obj file, then build again.
- cflags_c = [ "/wd4206" ]
}
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698