Remove *BinariesDistribution and ChromeBinariesOperations from installer_util.

Remove *BinariesDistribution and ChromeBinariesOperations from installer_util.

BUG=577816
Review-Url: https://codereview.chromium.org/2621713004
Cr-Commit-Position: refs/heads/master@{#442826}
Committed: https://chromium.googlesource.com/chromium/src/+/c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1

[grt (UTC plus 2), 2017-01-10 10:20:09]

Patchset #1 (id:1) has been deleted

[grt (UTC plus 2), 2017-01-10 10:23:17]

Patchset #1 (id:20001) has been deleted

[grt (UTC plus 2), 2017-01-10 10:23:25]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:23:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-01-10 10:24:15]

grt@chromium.org changed reviewers:
+ robertshield@chromium.org

[grt (UTC plus 2), 2017-01-10 10:24:15]

The cleansing continues! I have a followup CL that removes
BrowserDistribution::Type. Thanks for the reviews.

[commit-bot: I haz the power, 2017-01-10 10:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:26:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[grt (UTC plus 2), 2017-01-10 10:46:25]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:49:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:49:16]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[robertshield, 2017-01-10 14:49:30]

lgtm

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/b...
File chrome/installer/util/browser_distribution.cc (right):

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/b...
chrome/installer/util/browser_distribution.cc:81: BrowserDistribution*
BrowserDistribution::GetSpecificDistribution(
This method shrinking makes me so happy.

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/p...
File chrome/installer/util/product.h (right):

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/p...
chrome/installer/util/product.h:56: return distribution_->GetType() == type;
Probably doesn't matter since you're a one-man cleaning machine, but if Type
were going to persist, I'd say to add a DCHECK here that it is Chrome.

[grt (UTC plus 2), 2017-01-10 19:54:42]

Thank you, sir.

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/b...
File chrome/installer/util/browser_distribution.cc (right):

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/b...
chrome/installer/util/browser_distribution.cc:81: BrowserDistribution*
BrowserDistribution::GetSpecificDistribution(
On 2017/01/10 14:49:30, robertshield_slow_reviews wrote:
> This method shrinking makes me so happy.

How happy will you be if I remove BrowserDistribution altogether?

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/p...
File chrome/installer/util/product.h (right):

https://codereview.chromium.org/2621713004/diff/60001/chrome/installer/util/p...
chrome/installer/util/product.h:56: return distribution_->GetType() == type;
On 2017/01/10 14:49:30, robertshield_slow_reviews wrote:
> Probably doesn't matter since you're a one-man cleaning machine, but if Type
> were going to persist, I'd say to add a DCHECK here that it is Chrome.

The very next CL (https://codereview.chromium.org/2622883002/) removes  Type and
this method. :-)

[grt (UTC plus 2), 2017-01-11 05:33:45]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2017-01-11 05:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:36:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484112825918040,
"parent_rev": "78340b2f974fe411503a894d96bcdda2b4ac87e3", "commit_rev":
"c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1"}

[commit-bot: I haz the power, 2017-01-11 06:37:09]

Description was changed from

==========
Remove *BinariesDistribution and ChromeBinariesOperations from installer_util.

BUG=577816
==========

to

==========
Remove *BinariesDistribution and ChromeBinariesOperations from installer_util.

BUG=577816

Review-Url: https://codereview.chromium.org/2621713004
Cr-Commit-Position: refs/heads/master@{#442826}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6e4c6f1f9865b5a77d2cc4eb8c7...
==========

[commit-bot: I haz the power, 2017-01-11 06:37:10]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c6e4c6f1f9865b5a77d2cc4eb8c7...