Remove *BinariesDistribution and ChromeBinariesOperations from installer_util.

chrome/installer/util/product.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_PRODUCT_H_
 #define CHROME_INSTALLER_UTIL_PRODUCT_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 35 matching lines @@
   void InitializeFromPreferences(const MasterPreferences& prefs);
 
   void InitializeFromUninstallCommand(
       const base::CommandLine& uninstall_command);
 
   BrowserDistribution* distribution() const {
     return distribution_;
   }
 
   bool is_type(BrowserDistribution::Type type) const {
     return distribution_->GetType() == type;

[robertshield, 2017/01/10 14:49:30]

Probably doesn't matter since you're a one-man cleaning machine, but if Type
were going to persist, I'd say to add a DCHECK here that it is Chrome.

[grt (UTC plus 2), 2017/01/10 19:54:42]

The very next CL (https://codereview.chromium.org/2622883002/) removes  Type and
this method. :-)

   }
 
   bool is_chrome() const {
     return distribution_->GetType() == BrowserDistribution::CHROME_BROWSER;
   }
 
-  bool is_chrome_binaries() const {
-    return distribution_->GetType() == BrowserDistribution::CHROME_BINARIES;
-  }
-
   bool HasOption(const std::wstring& option) const {
     return options_.find(option) != options_.end();
   }
 
   // Returns true if the set of options is mutated by this operation.
   bool SetOption(const std::wstring& option, bool set) {
     if (set)
       return options_.insert(option).second;
     else
       return options_.erase(option) != 0;
@@ skipping 10 matching lines @@
   // The program part will be ignored.
   bool LaunchChromeAndWait(const base::FilePath& application_path,
                            const base::CommandLine& options,
                            int32_t* exit_code) const;
 
   // Sets the boolean MSI marker for this installation if set is true or clears
   // it otherwise. The MSI marker is stored in the registry under the
   // ClientState key.
   bool SetMsiMarker(bool system_install, bool set) const;
 
-  // Returns true if setup should create an entry in the Add/Remove list
-  // of installed applications.
-  bool ShouldCreateUninstallEntry() const;
-
   // See ProductOperations::AddKeyFiles.
   void AddKeyFiles(std::vector<base::FilePath>* key_files) const;
 
   // See ProductOperations::AppendProductFlags.
   void AppendProductFlags(base::CommandLine* command_line) const;
 
   // See ProductOperations::AppendRenameFlags.
   void AppendRenameFlags(base::CommandLine* command_line) const;
 
   // See Productoperations::SetChannelFlags.
@@ skipping 17 matching lines @@
   std::unique_ptr<ProductOperations> operations_;
   std::set<std::wstring> options_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Product);
 };
 
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_PRODUCT_H_