Keep track of coalesced events in main thread event queue

Keep track of coalesced events in main thread event queue

This CL keeps track of the coaleced events in the
main thread event queue and passes them to Blink. So
that Blink later exposes them to the js through
PointerEvent.getCoalescedEvents API.

BUG=680678
Review-Url: https://codereview.chromium.org/2621303004
Cr-Commit-Position: refs/heads/master@{#445528}
Committed: https://chromium.googlesource.com/chromium/src/+/5d8596504544ee64049242d88b15fc3a79295519

[Navid Zolghadr, 2017-01-12 21:36:57]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:37:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-12 21:53:16]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[Navid Zolghadr, 2017-01-12 21:53:17]

As for the tests I'm going to send the review to wpt.

[commit-bot: I haz the power, 2017-01-12 22:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:07:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Navid Zolghadr, 2017-01-13 02:40:25]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 02:41:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 02:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 02:47:29]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Navid Zolghadr, 2017-01-13 03:15:59]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 03:16:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-13 03:17:23]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 03:18:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 03:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 03:39:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Navid Zolghadr, 2017-01-13 03:56:42]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 03:57:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:32:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Navid Zolghadr, 2017-01-13 16:21:17]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:21:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-13 17:46:30]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 17:46:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-01-13 18:56:23]

https://codereview.chromium.org/2621303004/diff/100001/components/test_runner...
File components/test_runner/event_sender.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/components/test_runner...
components/test_runner/event_sender.cc:2818: return
widget()->handleInputEvent(blink::WebCoalescedInputEvent(*event));
Does it not make sense here to adjust TranslateAndScaleEvent to always clone an
event and then to move the scaled event into the WebCoalescedInputEvents here?

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
File content/renderer/input/main_thread_event_queue_unittest.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
content/renderer/input/main_thread_event_queue_unittest.cc:78:
std::vector<blink::WebScopedInputEvent> coalescedEvents;
Is it not possible to just update the handled_events_ queue to be
WebCoalescedInputEvents? Instead of a parallel list?

[Navid Zolghadr, 2017-01-13 19:02:11]

https://codereview.chromium.org/2621303004/diff/100001/components/test_runner...
File components/test_runner/event_sender.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/components/test_runner...
components/test_runner/event_sender.cc:2818: return
widget()->handleInputEvent(blink::WebCoalescedInputEvent(*event));
On 2017/01/13 18:56:23, dtapuska wrote:
> Does it not make sense here to adjust TranslateAndScaleEvent to always clone
an
> event and then to move the scaled event into the WebCoalescedInputEvents here?

I have done the modification to the generator functions in other places when in
every place we needed that cast. But in this particular case the other places
that the TransformScreenToWidgetCoordinate is used they don't all expect
WebCoalescedInputEvent.
Having said that, do you still think it is better to change that function?

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
File content/renderer/input/main_thread_event_queue_unittest.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
content/renderer/input/main_thread_event_queue_unittest.cc:78:
std::vector<blink::WebScopedInputEvent> coalescedEvents;
On 2017/01/13 18:56:23, dtapuska wrote:
> Is it not possible to just update the handled_events_ queue to be
> WebCoalescedInputEvents? Instead of a parallel list?

Yeah. I didn't like what I did either. Only when I updated the handled_event_ to
keep the coalesced ones as well then I had to update a lot more code lines in
this file. But if that is okay I'll update the handled_event_ itself to store
WebCoalescedInputEvent.

[dtapuska, 2017-01-13 19:10:23]

https://codereview.chromium.org/2621303004/diff/100001/components/test_runner...
File components/test_runner/event_sender.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/components/test_runner...
components/test_runner/event_sender.cc:2818: return
widget()->handleInputEvent(blink::WebCoalescedInputEvent(*event));
On 2017/01/13 19:02:10, Navid Zolghadr wrote:
> On 2017/01/13 18:56:23, dtapuska wrote:
> > Does it not make sense here to adjust TranslateAndScaleEvent to always clone
> an
> > event and then to move the scaled event into the WebCoalescedInputEvents
here?
> 
> I have done the modification to the generator functions in other places when
in
> every place we needed that cast. But in this particular case the other places
> that the TransformScreenToWidgetCoordinate is used they don't all expect
> WebCoalescedInputEvent.
> Having said that, do you still think it is better to change that function?

Ugh; I had clicked on it; but it is used in a number of places so it probably
isn't best to update its signature. It is just ugly that we have a scoped_ptr
for the WebInputEvent that we can't just use if it was the right type. Oh well.

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
File content/renderer/input/main_thread_event_queue_unittest.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
content/renderer/input/main_thread_event_queue_unittest.cc:78:
std::vector<blink::WebScopedInputEvent> coalescedEvents;
On 2017/01/13 19:02:10, Navid Zolghadr wrote:
> On 2017/01/13 18:56:23, dtapuska wrote:
> > Is it not possible to just update the handled_events_ queue to be
> > WebCoalescedInputEvents? Instead of a parallel list?
> 
> Yeah. I didn't like what I did either. Only when I updated the handled_event_
to
> keep the coalesced ones as well then I had to update a lot more code lines in
> this file. But if that is okay I'll update the handled_event_ itself to store
> WebCoalescedInputEvent. 

I'd prefer to have cleaner code than minimizing the amount of code changed.

[commit-bot: I haz the power, 2017-01-13 21:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:54:23]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-01-16 16:44:56]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 16:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-16 18:00:39]

Description was changed from

==========
Keep track of coalesced events for mousemoves and touchmoves

This CL passes the coaleced events for mousemove and
touchmove events to Blink so it can be later exposed
to the js through PointerEvent.getCoalescedEvents
API.

BUG=680678
==========

to

==========
Keep track of coalesced events in main thread event queue

This CL passes keeps track of the coaleced events in the
main thread event queue and passes them to Blink. So
that Blink later exposes them to the js through
PointerEvent.getCoalescedEvents API.

BUG=680678
==========

[Navid Zolghadr, 2017-01-16 18:01:55]

ptal.

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
File content/renderer/input/main_thread_event_queue_unittest.cc (right):

https://codereview.chromium.org/2621303004/diff/100001/content/renderer/input...
content/renderer/input/main_thread_event_queue_unittest.cc:78:
std::vector<blink::WebScopedInputEvent> coalescedEvents;
On 2017/01/13 19:10:23, dtapuska wrote:
> On 2017/01/13 19:02:10, Navid Zolghadr wrote:
> > On 2017/01/13 18:56:23, dtapuska wrote:
> > > Is it not possible to just update the handled_events_ queue to be
> > > WebCoalescedInputEvents? Instead of a parallel list?
> > 
> > Yeah. I didn't like what I did either. Only when I updated the
handled_event_
> to
> > keep the coalesced ones as well then I had to update a lot more code lines
in
> > this file. But if that is okay I'll update the handled_event_ itself to
store
> > WebCoalescedInputEvent. 
> 
> I'd prefer to have cleaner code than minimizing the amount of code changed.

Done.

[commit-bot: I haz the power, 2017-01-16 18:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 18:07:14]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-01-18 17:12:23]

ping

[dtapuska, 2017-01-18 18:25:02]

On 2017/01/18 17:12:23, Navid Zolghadr wrote:
> ping

lgtm

[Navid Zolghadr, 2017-01-18 18:33:55]

nzolghadr@chromium.org changed reviewers:
+ kinuko@chromium.org, rbyers@chromium.org, sdefresne@chromium.org

[Navid Zolghadr, 2017-01-18 18:33:56]

kinuko@chromium.org: Please review changes in 
content/*

sdefresne@chromium.org: Please review changes in 
components/*

rbyers@chromium.org: Please review changes in 
thirdparty/Webkit/*

[sdefresne, 2017-01-19 12:18:49]

sdefresne@chromium.org changed reviewers:
+ bauerb@chromium.org, tommyw@chromium.org

[sdefresne, 2017-01-19 12:18:50]

bauerb: components/plugins
tommyw: components/test_runner

I think this needs review by OWNERs of the specifics components and my stamp is
not good enough.

[kinuko, 2017-01-19 13:40:18]

lgtm

https://codereview.chromium.org/2621303004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp
(right):

https://codereview.chromium.org/2621303004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp:118: :
m_event(), m_coalescedEvents() {
I don't think we need these empty initializers here?  (unique_ptr and vector's
default ctor would do it)

[Bernhard Bauer, 2017-01-19 17:24:19]

components/plugins/ RS LGTM.

[Navid Zolghadr, 2017-01-19 21:08:38]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-19 21:46:25]

https://codereview.chromium.org/2621303004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp
(right):

https://codereview.chromium.org/2621303004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp:118: :
m_event(), m_coalescedEvents() {
On 2017/01/19 13:40:18, kinuko wrote:
> I don't think we need these empty initializers here?  (unique_ptr and vector's
> default ctor would do it)

Done.

[commit-bot: I haz the power, 2017-01-19 23:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:34:00]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2017-01-20 17:55:10]

WebKit/public LGTM

Rest of WebKit RS LGTM - dtapuska@ is an expert here, no need for additional
review.

[Navid Zolghadr, 2017-01-23 16:09:15]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-01-23 16:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
dtapuska@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2621303004/#ps140001
(title: "Remove redundant initializer lists")

[commit-bot: I haz the power, 2017-01-23 16:09:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 16:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:11:22]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Navid Zolghadr, 2017-01-23 17:10:18]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 17:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-23 17:20:49]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-01-23 17:20:50]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-01-23 17:20:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
dtapuska@chromium.org, rbyers@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2621303004/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-23 17:21:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 17:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 17:29:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Navid Zolghadr, 2017-01-23 17:34:30]

nzolghadr@chromium.org changed reviewers:
+ dcheng@chromium.org

[Navid Zolghadr, 2017-01-23 17:34:31]

dcheng@chromium.org: Please review changes in

content/common/input_messages.h

[dcheng, 2017-01-23 19:38:58]

Mostly nits.

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
File content/common/input/event_with_latency_info.cc (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
content/common/input/event_with_latency_info.cc:14: : event_(new
blink::WebCoalescedInputEvent(std::move(event))),
Not required in this CL, but maybe WebCoalescedInputEvent should just be movable
itself, so we can avoid another indirection?

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
File content/common/input/event_with_latency_info.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
content/common/input/event_with_latency_info.h:31: const
blink::WebCoalescedInputEvent& coalescedEvent() const;
Nit: Per Chromium naming conventions, this should be named coalesced_event() or
GetCoalescedEvent().

https://codereview.chromium.org/2621303004/diff/160001/content/common/input_m...
File content/common/input_messages.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input_m...
content/common/input_messages.h:141: std::vector<IPC::WebInputEventPointer> /*
coalesced ones*/,
Nit: ones => events (also one space before */)

It would also be nice if the comment for this IPC message could elaborate a bit
more on what "coalesced events" are -- this could just be a pointer to another
part of the code, if it's already documented somewhere.

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/idle_...
File content/renderer/idle_user_detector.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/idle_...
content/renderer/idle_user_detector.h:38: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
Nit: coalesced_events here and in the .cc

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_view_impl.cc:2718: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
Though I'm a little surprised that this doesn't seem to be used?

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_view_impl.h:647: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
Nit: coalesced_events here and in the .cc

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_widget.h:479: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
Nit: naming here and the rest of this CL (that's ouside Blink) as well

[Navid Zolghadr, 2017-01-23 19:44:51]

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
File content/common/input/event_with_latency_info.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
content/common/input/event_with_latency_info.h:31: const
blink::WebCoalescedInputEvent& coalescedEvent() const;
On 2017/01/23 19:38:58, dcheng wrote:
> Nit: Per Chromium naming conventions, this should be named coalesced_event()
or
> GetCoalescedEvent().

So is the latencyInfo() also incorrect?

[dcheng, 2017-01-23 20:35:47]

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
File content/common/input/event_with_latency_info.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
content/common/input/event_with_latency_info.h:31: const
blink::WebCoalescedInputEvent& coalescedEvent() const;
On 2017/01/23 19:44:50, Navid Zolghadr wrote:
> On 2017/01/23 19:38:58, dcheng wrote:
> > Nit: Per Chromium naming conventions, this should be named coalesced_event()
> or
> > GetCoalescedEvent().
> 
> So is the latencyInfo() also incorrect?

Yes, but a bit unrelated, so I didn't mention it

[Navid Zolghadr, 2017-01-23 21:02:12]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 21:03:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-23 21:05:30]

Description was changed from

==========
Keep track of coalesced events in main thread event queue

This CL passes keeps track of the coaleced events in the
main thread event queue and passes them to Blink. So
that Blink later exposes them to the js through
PointerEvent.getCoalescedEvents API.

BUG=680678
==========

to

==========
Keep track of coalesced events in main thread event queue

This CL keeps track of the coaleced events in the
main thread event queue and passes them to Blink. So
that Blink later exposes them to the js through
PointerEvent.getCoalescedEvents API.

BUG=680678
==========

[commit-bot: I haz the power, 2017-01-23 21:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:06:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Navid Zolghadr, 2017-01-23 21:22:26]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 21:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-01-23 21:42:05]

ptal.

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
File content/common/input/event_with_latency_info.cc (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
content/common/input/event_with_latency_info.cc:14: : event_(new
blink::WebCoalescedInputEvent(std::move(event))),
On 2017/01/23 19:38:58, dcheng wrote:
> Not required in this CL, but maybe WebCoalescedInputEvent should just be
movable
> itself, so we can avoid another indirection?

Acknowledged.

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
File content/common/input/event_with_latency_info.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input/e...
content/common/input/event_with_latency_info.h:31: const
blink::WebCoalescedInputEvent& coalescedEvent() const;
On 2017/01/23 20:35:47, dcheng wrote:
> On 2017/01/23 19:44:50, Navid Zolghadr wrote:
> > On 2017/01/23 19:38:58, dcheng wrote:
> > > Nit: Per Chromium naming conventions, this should be named
coalesced_event()
> > or
> > > GetCoalescedEvent().
> > 
> > So is the latencyInfo() also incorrect?
> 
> Yes, but a bit unrelated, so I didn't mention it 

Done.

https://codereview.chromium.org/2621303004/diff/160001/content/common/input_m...
File content/common/input_messages.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/common/input_m...
content/common/input_messages.h:141: std::vector<IPC::WebInputEventPointer> /*
coalesced ones*/,
On 2017/01/23 19:38:58, dcheng wrote:
> Nit: ones => events (also one space before */)
> 
> It would also be nice if the comment for this IPC message could elaborate a
bit
> more on what "coalesced events" are -- this could just be a pointer to another
> part of the code, if it's already documented somewhere.

Done.

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/idle_...
File content/renderer/idle_user_detector.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/idle_...
content/renderer/idle_user_detector.h:38: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
On 2017/01/23 19:38:58, dcheng wrote:
> Nit: coalesced_events here and in the .cc

Done.

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_view_impl.cc:2718: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
On 2017/01/23 19:38:58, dcheng wrote:
> Though I'm a little surprised that this doesn't seem to be used?

I believe there are some paths that may still need some plumbing. I just didn't
want to do it all in one patch. So far this CL at least addresses the portion of
the usecase we needed. More of the plumbing can be done later when we face the
need in different scenarios.

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_view_impl.h:647: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
On 2017/01/23 19:38:58, dcheng wrote:
> Nit: coalesced_events here and in the .cc

Done.

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_widget.h:479: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
On 2017/01/23 19:38:58, dcheng wrote:
> Nit: naming here and the rest of this CL (that's ouside Blink) as well

Done and also done in the rest of the CL. I hope I didn't miss anything.

[dcheng, 2017-01-23 21:46:26]

LGTM with a nit

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2621303004/diff/160001/content/renderer/rende...
content/renderer/render_view_impl.cc:2718: const std::vector<const
blink::WebInputEvent*>& coalescedEvents,
On 2017/01/23 21:42:04, Navid Zolghadr wrote:
> On 2017/01/23 19:38:58, dcheng wrote:
> > Though I'm a little surprised that this doesn't seem to be used?
> 
> I believe there are some paths that may still need some plumbing. I just
didn't
> want to do it all in one patch. So far this CL at least addresses the portion
of
> the usecase we needed. More of the plumbing can be done later when we face the
> need in different scenarios.

Might be better to just add it when it's needed? I think it's needed everywhere
else, and if we find this plumbing is missing later, it's easy enough to add it
back.

[Navid Zolghadr, 2017-01-23 21:54:57]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-01-23 21:55:05]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-01-23 21:55:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
dtapuska@chromium.org, rbyers@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2621303004/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-23 21:56:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:59:40]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1485208505222620,
"parent_rev": "22632c56f2fe702261795bb3cd3f76a717addf4a", "commit_rev":
"5d8596504544ee64049242d88b15fc3a79295519"}

[commit-bot: I haz the power, 2017-01-23 23:00:15]

Description was changed from

==========
Keep track of coalesced events in main thread event queue

This CL keeps track of the coaleced events in the
main thread event queue and passes them to Blink. So
that Blink later exposes them to the js through
PointerEvent.getCoalescedEvents API.

BUG=680678
==========

to

==========
Keep track of coalesced events in main thread event queue

This CL keeps track of the coaleced events in the
main thread event queue and passes them to Blink. So
that Blink later exposes them to the js through
PointerEvent.getCoalescedEvents API.

BUG=680678

Review-Url: https://codereview.chromium.org/2621303004
Cr-Commit-Position: refs/heads/master@{#445528}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d8596504544ee64049242d88b15...
==========

[commit-bot: I haz the power, 2017-01-23 23:00:17]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/5d8596504544ee64049242d88b15...