Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2621303004: Keep track of coalesced events in main thread event queue (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index 15ec9d455aa7f6dfb41f7ec31aa17e8f16cf0619..74884f37fc6a0d69fd905dc5edd84b482f88c574 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -1167,12 +1167,12 @@ TEST_P(VisualViewportTest, TestContextMenuShownInCorrectLocation) {
// Do a sanity check with no scale applied.
webViewImpl()->mainFrameImpl()->setClient(&mockWebFrameClient);
- webViewImpl()->handleInputEvent(mouseDownEvent);
- webViewImpl()->handleInputEvent(mouseUpEvent);
+ webViewImpl()->handleInputEvent(WebCoalescedInputEvent(mouseDownEvent));
+ webViewImpl()->handleInputEvent(WebCoalescedInputEvent(mouseUpEvent));
Mock::VerifyAndClearExpectations(&mockWebFrameClient);
mouseDownEvent.button = WebMouseEvent::Button::Left;
- webViewImpl()->handleInputEvent(mouseDownEvent);
+ webViewImpl()->handleInputEvent(WebCoalescedInputEvent(mouseDownEvent));
// Now pinch zoom into the page and move the visual viewport. The context menu
// should still appear at the location of the event, relative to the WebView.
@@ -1185,8 +1185,8 @@ TEST_P(VisualViewportTest, TestContextMenuShownInCorrectLocation) {
mouseDownEvent.x, mouseDownEvent.y)));
mouseDownEvent.button = WebMouseEvent::Button::Right;
- webViewImpl()->handleInputEvent(mouseDownEvent);
- webViewImpl()->handleInputEvent(mouseUpEvent);
+ webViewImpl()->handleInputEvent(WebCoalescedInputEvent(mouseDownEvent));
+ webViewImpl()->handleInputEvent(WebCoalescedInputEvent(mouseUpEvent));
// Reset the old client so destruction can occur naturally.
webViewImpl()->mainFrameImpl()->setClient(oldClient);
@@ -2015,7 +2015,7 @@ TEST_P(VisualViewportTest, PinchZoomGestureScrollsVisualViewportOnly) {
pinchUpdate.data.pinchUpdate.scale = 2;
pinchUpdate.data.pinchUpdate.zoomDisabled = false;
- webViewImpl()->handleInputEvent(pinchUpdate);
+ webViewImpl()->handleInputEvent(WebCoalescedInputEvent(pinchUpdate));
VisualViewport& visualViewport =
webViewImpl()->page()->frameHost().visualViewport();
« no previous file with comments | « third_party/WebKit/Source/web/tests/TouchActionTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698