Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2621303004: Keep track of coalesced events in main thread event queue (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 504
505 bool WebPagePopupImpl::isViewportPointInWindow(int x, int y) { 505 bool WebPagePopupImpl::isViewportPointInWindow(int x, int y) {
506 WebRect pointInWindow(x, y, 0, 0); 506 WebRect pointInWindow(x, y, 0, 0);
507 widgetClient()->convertViewportToWindow(&pointInWindow); 507 widgetClient()->convertViewportToWindow(&pointInWindow);
508 WebRect windowRect = windowRectInScreen(); 508 WebRect windowRect = windowRectInScreen();
509 return IntRect(0, 0, windowRect.width, windowRect.height) 509 return IntRect(0, 0, windowRect.width, windowRect.height)
510 .contains(IntPoint(pointInWindow.x, pointInWindow.y)); 510 .contains(IntPoint(pointInWindow.x, pointInWindow.y));
511 } 511 }
512 512
513 WebInputEventResult WebPagePopupImpl::handleInputEvent( 513 WebInputEventResult WebPagePopupImpl::handleInputEvent(
514 const WebInputEvent& event) { 514 const WebCoalescedInputEvent& event) {
515 if (m_closing) 515 if (m_closing)
516 return WebInputEventResult::NotHandled; 516 return WebInputEventResult::NotHandled;
517 return PageWidgetDelegate::handleInputEvent( 517 return PageWidgetDelegate::handleInputEvent(
518 *this, WebCoalescedInputEvent(event), m_page->deprecatedLocalMainFrame()); 518 *this, event, m_page->deprecatedLocalMainFrame());
519 } 519 }
520 520
521 void WebPagePopupImpl::setFocus(bool enable) { 521 void WebPagePopupImpl::setFocus(bool enable) {
522 if (!m_page) 522 if (!m_page)
523 return; 523 return;
524 m_page->focusController().setFocused(enable); 524 m_page->focusController().setFocused(enable);
525 if (enable) 525 if (enable)
526 m_page->focusController().setActive(true); 526 m_page->focusController().setActive(true);
527 } 527 }
528 528
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 // A WebPagePopupImpl instance usually has two references. 600 // A WebPagePopupImpl instance usually has two references.
601 // - One owned by the instance itself. It represents the visible widget. 601 // - One owned by the instance itself. It represents the visible widget.
602 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 602 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
603 // WebPagePopupImpl to close. 603 // WebPagePopupImpl to close.
604 // We need them because the closing operation is asynchronous and the widget 604 // We need them because the closing operation is asynchronous and the widget
605 // can be closed while the WebViewImpl is unaware of it. 605 // can be closed while the WebViewImpl is unaware of it.
606 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 606 return adoptRef(new WebPagePopupImpl(client)).leakRef();
607 } 607 }
608 608
609 } // namespace blink 609 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698