Reduce PropertyTreeState construction and copies

third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintInvalidator.h"
 
 #include "core/editing/FrameSelection.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
@@ skipping 30 matching lines @@
 }
 
 // TODO(wangxianzhu): Combine this into
 // PaintInvalidator::mapLocalRectToBacking() when removing
 // PaintInvalidationState.
 static LayoutRect mapLocalRectToPaintInvalidationBacking(
     GeometryMapper& geometryMapper,
     const LayoutObject& object,
     const FloatRect& localRect,
     const PaintInvalidatorContext& context) {
+  bool isSVGChild = object.isSVGChild();
+
   // TODO(wkorman): The flip below is required because visual rects are
   // currently in "physical coordinates with flipped block-flow direction"
   // (see LayoutBoxModelObject.h) but we need them to be in physical
   // coordinates.
   FloatRect rect = localRect;
   // Writing-mode flipping doesn't apply to non-root SVG.
-  if (!object.isSVGChild()) {
+  if (!isSVGChild) {
     if (object.isBox()) {
       toLayoutBox(object).flipForWritingMode(rect);
     } else if (!(context.forcedSubtreeInvalidationFlags &
                  PaintInvalidatorContext::ForcedSubtreeSlowPathRect)) {
       // For SPv2 and the GeometryMapper path, we also need to convert the rect
       // for non-boxes into physical coordinates before applying paint offset.
       // (Otherwise we'll call mapToVisualrectInAncestorSpace() which requires
       // physical coordinates for boxes, but "physical coordinates with flipped
       // block-flow direction" for non-boxes for which we don't need to flip.)
       // TODO(wangxianzhu): Avoid containingBlock().
       object.containingBlock()->flipForWritingMode(rect);
     }
   }
 
   if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
     // In SPv2, visual rects are in the space of their local transform node.
     // For SVG, the input rect is in local SVG coordinates in which paint
     // offset doesn't apply.
-    if (!object.isSVGChild())
+    if (!isSVGChild)
       rect.moveBy(FloatPoint(object.paintOffset()));
     // Use enclosingIntRect to ensure the final visual rect will cover the
     // rect in source coordinates no matter if the painting will use pixel
     // snapping.
     return LayoutRect(enclosingIntRect(rect));
   }
 
   LayoutRect result;
   if (context.forcedSubtreeInvalidationFlags &
       PaintInvalidatorContext::ForcedSubtreeSlowPathRect) {
     result = slowMapToVisualRectInAncestorSpace(
         object, *context.paintInvalidationContainer, rect);
   } else if (object == context.paintInvalidationContainer) {
     result = LayoutRect(rect);
   } else {
     // For non-root SVG, the input rect is in local SVG coordinates in which
     // paint offset doesn't apply.
-    if (!object.isSVGChild()) {
+    if (!isSVGChild) {
       rect.moveBy(FloatPoint(object.paintOffset()));
       // Use enclosingIntRect to ensure the final visual rect will cover the
       // rect in source coordinates no matter if the painting will use pixel
       // snapping.
       rect = enclosingIntRect(rect);
     }
 
-    PropertyTreeState currentTreeState(
-        context.treeBuilderContext.current.transform,
-        context.treeBuilderContext.current.clip,
-        context.treeBuilderContext.currentEffect,
-        context.treeBuilderContext.current.scroll);
-    const auto* containerPaintProperties =
-        context.paintInvalidationContainer->paintProperties();
-    auto containerContentsProperties =
-        containerPaintProperties->contentsProperties();
-
-    bool success = false;
-    result = LayoutRect(geometryMapper.sourceToDestinationVisualRect(
-        rect, currentTreeState, containerContentsProperties, success));
-    DCHECK(success);
+    const auto* containerContentsProperties =
+        context.paintInvalidationContainer->paintProperties()
+            ->contentsProperties();
+    if (context.treeBuilderContext.current.transform ==
+            containerContentsProperties->transform() &&
+        context.treeBuilderContext.current.clip ==
+            containerContentsProperties->clip()) {
+      result = LayoutRect(rect);
+    } else {
+      PropertyTreeState currentTreeState(
+          context.treeBuilderContext.current.transform,
+          context.treeBuilderContext.current.clip, nullptr, nullptr);
+      bool success = false;
+      result = LayoutRect(geometryMapper.sourceToDestinationVisualRect(
+          rect, currentTreeState, *containerContentsProperties, success));
+      DCHECK(success);
+    }
 
     // Convert the result to the container's contents space.
     result.moveBy(-context.paintInvalidationContainer->paintOffset());
   }
 
   object.adjustVisualRectForRasterEffects(result);
 
   PaintLayer::mapRectInPaintInvalidationContainerToBacking(
       *context.paintInvalidationContainer, result);
 
@@ skipping 29 matching lines @@
 }
 
 LayoutPoint PaintInvalidator::computeLocationInBacking(
     const LayoutObject& object,
     const PaintInvalidatorContext& context) {
   // Use visual rect location for LayoutTexts because it suffices to check
   // visual rect change for layout caused invalidation.
   if (object.isText())
     return context.newVisualRect.location();
 
-  FloatPoint point;
+  LayoutPoint point;
   if (object != context.paintInvalidationContainer) {
-    point.moveBy(FloatPoint(object.paintOffset()));
+    point.moveBy(object.paintOffset());
 
-    const auto* containerPaintProperties =
-        context.paintInvalidationContainer->paintProperties();
-    auto containerContentsProperties =
-        containerPaintProperties->contentsProperties();
-
-    bool success = false;
-    point = m_geometryMapper
-                .sourceToDestinationRect(
-                    FloatRect(point, FloatSize()),
-                    context.treeBuilderContext.current.transform,
-                    containerContentsProperties.transform(), success)
-                .location();
-    DCHECK(success);
+    const auto* containerTransform =
+        context.paintInvalidationContainer->paintProperties()
+            ->contentsProperties()
+            ->transform();
+    if (context.treeBuilderContext.current.transform != containerTransform) {
+      bool success = false;
+      point = LayoutPoint(m_geometryMapper
+                              .sourceToDestinationRect(
+                                  FloatRect(FloatPoint(point), FloatSize()),
+                                  context.treeBuilderContext.current.transform,
+                                  containerTransform, success)
+                              .location());
+      DCHECK(success);
+    }
 
     // Convert the result to the container's contents space.
     point.moveBy(-context.paintInvalidationContainer->paintOffset());
   }
 
-  PaintLayer::mapPointInPaintInvalidationContainerToBacking(
-      *context.paintInvalidationContainer, point);
+  if (context.paintInvalidationContainer->layer()->groupedMapping()) {
+    FloatPoint floatPoint(point);
+    PaintLayer::mapPointInPaintInvalidationContainerToBacking(
+        *context.paintInvalidationContainer, floatPoint);
+    point = LayoutPoint(floatPoint);
+  }
 
-  return LayoutPoint(point);
+  return point;
 }
 
 void PaintInvalidator::updatePaintingLayer(const LayoutObject& object,
                                            PaintInvalidatorContext& context) {
   if (object.hasLayer() &&
       toLayoutBoxModelObject(object).hasSelfPaintingLayer()) {
     context.paintingLayer = toLayoutBoxModelObject(object).layer();
   } else if (object.isColumnSpanAll() ||
              (object.isFloating() && !object.parent()->isLayoutBlock())) {
     // See LayoutObject::paintingLayer() for the special-cases of floating under
@@ skipping 245 matching lines @@
         PaintInvalidatorContext::ForcedSubtreeInvalidationRectUpdate;
 }
 
 void PaintInvalidator::processPendingDelayedPaintInvalidations() {
   for (auto target : m_pendingDelayedPaintInvalidations)
     target->getMutableForPainting().setShouldDoFullPaintInvalidation(
         PaintInvalidationDelayedFull);
 }
 
 }  // namespace blink